New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip SetChecksum on Windows #24

Merged

mdlayher merged 1 commit into mdlayher:master from rtpt-erikgeiser:skip_checksum_on_windows

Jun 22, 2021

Contributor

rtpt-erikgeiser commented Jun 22, 2021

This PR fixes #23 by skipping the call to (*icmp.PacketConn).SetChecksum in Dial when GOOS is "windows".


          Skip SetChecksum on Windows

b082d05

mdlayher approved these changes

View reviewed changes

Owner

mdlayher commented Jun 22, 2021

LGTM.

mdlayher merged commit 66aaad7 into mdlayher:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet