Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created the newsletter with proper functioning and validation pop up #691

Merged
merged 9 commits into from
Jun 27, 2024

Conversation

Ayushmaanagarwal1211
Copy link
Contributor

I've added the proper pop up and proper functioning of the newsletter

i enhanced the design of the search bar as well
Now on submitting the user will see proper message in proper pop up that will looks amazing and also indicate the user about the current state of his/her request .

closes : #668

bandicam.2024-06-27.13-19-08-871.mp4

Copy link

vercel bot commented Jun 27, 2024

@Ayushmaanagarwal1211 is attempting to deploy a commit to the MD AZFAR ALAM's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

vercel bot commented Jun 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
helpops-hub2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2024 8:54am

@shreyash3087
Copy link
Contributor

shreyash3087 commented Jun 27, 2024

Kindly make sure that you have added the popup card for this also- #690

It should show You are already subscribed to the Newsletter! in popup as well,if you are entering duplicate mail ids

@Ayushmaanagarwal1211
Copy link
Contributor Author

Bro i did discussion with afzar aslam for the same

@shreyash3087
Copy link
Contributor

yes so add your popup for that message as well since its just added

@Ayushmaanagarwal1211
Copy link
Contributor Author

@shreyash3087 bro i know that i have to add it was creating conflict that's why i will do that after merging this
Bro i know what i am doing @mdazfar2 he know

@shreyash3087
Copy link
Contributor

@Ayushmaanagarwal1211 Alright thats fine then

Copy link
Owner

@mdazfar2 mdazfar2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's amazing!

  • Try to resolve for already subscribed and will give you the loading effect and will change with current ones.

@mdazfar2 mdazfar2 merged commit e647b74 into mdazfar2:main Jun 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants