Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Scroll down progress bar" #644

Closed
wants to merge 11 commits into from
Closed

Conversation

MastanSayyad
Copy link

@MastanSayyad MastanSayyad commented Jun 25, 2024

Hey @mdazfar2 | closes #608

I have added the "Scroll down progress bar" to the website

Changes I made:

  • Created progress.js file
  • Included logic to reset the scroll progress on page navigation using Next.js's usePathname hook.
  • Added CSS in global.css

This improves navigation efficiency and overall user experience, particularly on lengthy pages.

(Note: if we try to match background theme then the bar leads to blending issue so tried to use closest color as possible)

b.mp4

Please review the changes and consider merging this pull request,
Also I request you to add level 2 label if possible, Thank You!!

Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
helpops-hub2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 4:38pm

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@mdazfar2
Copy link
Owner

hey @MastanSayyad it doesn't looks good as usual could you remove these all changes and try to change the color of this one:


image

@mdazfar2 mdazfar2 added WIP work in progress by other contributor need change labels Jun 25, 2024
@MastanSayyad
Copy link
Author

its Vertical Scroll-bar @mdazfar2

@MastanSayyad
Copy link
Author

MastanSayyad commented Jun 25, 2024

@mdazfar2 okay got it, you mean remove the progress bar and adjust the color of vertical scroll-bar

@mdazfar2
Copy link
Owner

mdazfar2 commented Jun 25, 2024

@mdazfar2 okay got it, you mean remove the progress bar and adjust the color of vertical scroll-bar

yes @MastanSayyad and also try to add comment which and where you changes and why

@MastanSayyad
Copy link
Author

@mdazfar2 done the changes

image

image

b.mp4

@mdazfar2
Copy link
Owner

@MastanSayyad in dark mode it doesn't change

@MastanSayyad
Copy link
Author

which browser are you using? @mdazfar2

@mdazfar2
Copy link
Owner

@MastanSayyad
Edge

@MastanSayyad
Copy link
Author

@mdazfar2 ensure you clear your browser cache , in chrome browser it works fine, still I'll try to customize it for edge compatibilty

@MastanSayyad
Copy link
Author

@mdazfar2 this should work fine, if not then try chrome browser

@mdazfar2
Copy link
Owner

@mdazfar2 this should work fine, if not then try chrome browser

@MastanSayyad It is also doesn't work in chrome

@MastanSayyad
Copy link
Author

In only dark mode right?

@mdazfar2
Copy link
Owner

@MastanSayyad
yes

@MastanSayyad
Copy link
Author

okay, got it!

@MastanSayyad
Copy link
Author

@mdazfar2 this should work fine

Copy link

vercel bot commented Jun 30, 2024

@MastanSayyad is attempting to deploy a commit to the MD AZFAR ALAM's projects Team on Vercel.

A member of the Team first needs to authorize it.

@MastanSayyad
Copy link
Author

@mdazfar2 pls merge this PR

@mdazfar2
Copy link
Owner

@MastanSayyad kindly resolve your conflict then i can deploy your changes

@MastanSayyad
Copy link
Author

@mdazfar2 Resolved

@MastanSayyad
Copy link
Author

@mdazfar2 conflicts are resolved

@mdazfar2
Copy link
Owner

mdazfar2 commented Jul 1, 2024

hey @MastanSayyad I apologize, but I need to close this pull request for now. Please don't be discouraged! We can work together ono another issue if you want :)

@mdazfar2 mdazfar2 closed this Jul 1, 2024
@MastanSayyad
Copy link
Author

It's fine, I can understand! @mdazfar2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need change WIP work in progress by other contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Feat: Add a "Scroll down progress bar"
2 participants