-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "Scroll down progress bar" #644
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
hey @MastanSayyad it doesn't looks good as usual could you remove these all changes and try to change the color of this one: |
its Vertical Scroll-bar @mdazfar2 |
@mdazfar2 okay got it, you mean remove the progress bar and adjust the color of vertical scroll-bar |
yes @MastanSayyad and also try to add comment which and where you changes and why |
@mdazfar2 done the changes b.mp4 |
@MastanSayyad in dark mode it doesn't change |
which browser are you using? @mdazfar2 |
@MastanSayyad |
@mdazfar2 ensure you clear your browser cache , in chrome browser it works fine, still I'll try to customize it for edge compatibilty |
@mdazfar2 this should work fine, if not then try chrome browser |
@MastanSayyad It is also doesn't work in chrome |
In only dark mode right? |
@MastanSayyad |
okay, got it! |
@mdazfar2 this should work fine |
@MastanSayyad is attempting to deploy a commit to the MD AZFAR ALAM's projects Team on Vercel. A member of the Team first needs to authorize it. |
@mdazfar2 pls merge this PR |
@MastanSayyad kindly resolve your conflict then i can deploy your changes |
@mdazfar2 Resolved |
@mdazfar2 conflicts are resolved |
hey @MastanSayyad I apologize, but I need to close this pull request for now. Please don't be discouraged! We can work together ono another issue if you want :) |
It's fine, I can understand! @mdazfar2 |
Hey @mdazfar2 | closes #608
I have added the "Scroll down progress bar" to the website
Changes I made:
progress.js
fileusePathname
hook.global.css
This improves navigation efficiency and overall user experience, particularly on lengthy pages.
(Note: if we try to match background theme then the bar leads to blending issue so tried to use closest color as possible)
b.mp4
Please review the changes and consider merging this pull request,
Also I request you to add level 2 label if possible, Thank You!!