Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added scroll to top button #244

Closed
wants to merge 5 commits into from
Closed

added scroll to top button #244

wants to merge 5 commits into from

Conversation

dhruv8433
Copy link
Contributor

@mdazfar2

BUG: Missing Scroll to top button #242

close #242

i added scroll to top button in right side cornor
image

Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
helpops-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 6:39am

Copy link

github-actions bot commented Jun 6, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@dhruv8433
Copy link
Contributor Author

@mdazfar2

please check this and merge it

@mdazfar2
Copy link
Owner

mdazfar2 commented Jun 6, 2024

@dhruv8433 Couldn't find


image

@dhruv8433
Copy link
Contributor Author

@mdazfar2

now check it's working

@mdazfar2
Copy link
Owner

mdazfar2 commented Jun 6, 2024

Look a new bug was found from your changes. @dhruv8433

2024-06-06.15-14-24.mp4

@mdazfar2 mdazfar2 added bug Something isn't working pending this issue may be closed isn't me labels Jun 6, 2024
@dhruv8433
Copy link
Contributor Author

dhruv8433 commented Jun 6, 2024

@mdazfar2

please check out files changed
i only add css for display scroll to top and one button
i don't even touch faqs logic fiile

i only update 2 fiiles one faqs.html to add button
and css
image

the bug is not from my code please check

image

image

you can clearly chech this or file changed tab

@dhruv8433
Copy link
Contributor Author

dhruv8433 commented Jun 6, 2024

check this, i already solved feeback form in responsive in #238
but it still not looking responsive in live web

image

@dhruv8433
Copy link
Contributor Author

dhruv8433 commented Jun 6, 2024

@mdazfar2

please check this and merge it
i completed burger menu please merge it so i can make new pr

@dhruv8433
Copy link
Contributor Author

@mdazfar2

please merge this so i can create new pr

@mdazfar2
Copy link
Owner

mdazfar2 commented Jun 6, 2024

@dhruv8433 let me sharing new issue it is not updated yet

@dhruv8433
Copy link
Contributor Author

ok

@dhruv8433
Copy link
Contributor Author

@mdazfar2

please share me new issue
i will do it

@mdazfar2
Copy link
Owner

mdazfar2 commented Jun 6, 2024

I'll be continue from 10 pm okk

@dhruv8433
Copy link
Contributor Author

@mdazfar2

Ok no problem
Kindly review it and merge it

@mdazfar2
Copy link
Owner

mdazfar2 commented Jun 6, 2024

@dhruv8433

IMG_20240606_194811.jpg

  • try to create the footer like that create issue on that and start working it.

Copy link

netlify bot commented Jun 7, 2024

Deploy Preview for helpops-hub failed.

Name Link
🔨 Latest commit 26f4168
🔍 Latest deploy log https://app.netlify.com/sites/helpops-hub/deploys/6662ab0364ec9b000833f80d

@dhruv8433
Copy link
Contributor Author

@mdazfar2

i added footer with social media icons
image

if you need anythign else please inform me

@dhruv8433
Copy link
Contributor Author

pull from upsteram and resolve all the conflicts now you can check it and tell me if you need any kind of changes

@mdazfar2 mdazfar2 added no need thanks for issue but we already done it let you know need change labels Jun 7, 2024
Copy link

This PR has been automatically closed due to inactivity from the owner for 15 days.

@github-actions github-actions bot added the Stale label Jun 23, 2024
@github-actions github-actions bot closed this Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working isn't me let you know need change no need thanks for issue but we already done it pending this issue may be closed Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Missing Scroll to top button
2 participants