Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Card Alignment and Overflow #241

Merged
merged 4 commits into from
Jun 6, 2024
Merged

[Bug]: Card Alignment and Overflow #241

merged 4 commits into from
Jun 6, 2024

Conversation

shreyash3087
Copy link
Contributor

Description:

This PR fixes the Card Alignment on the contributors page and resolves the card-overflow issue on smaller devices.

Issue Mentioned:

Closes #211

Overflow Bug:

helpops.mp4

Changes made:

  • Removed the Padding from team-grid.
  • Changed Height to auto which was previously causing the error of team card-overflow

Screenshots:

Screenshot (210)

Additional Context:

N/A

Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
helpops-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 9:37am

Copy link

github-actions bot commented Jun 6, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@shreyash3087
Copy link
Contributor Author

@mdazfar2 along with the alignment i found an overflow issue with the team cards as well so i resolved both,kindly verify,it was just a small bug,nothing major.

@mdazfar2
Copy link
Owner

mdazfar2 commented Jun 6, 2024

@shreyash3087 I told you that you need to move the contributor card and text card here and there. But you have moved the founder card and maintainer card here and there.

image

this is what i want please see the highlight line it touches the founder card and maintainer card which means you don't have to move those card but you moved.

image


  • Hope you understand what i want to say

@mdazfar2 mdazfar2 added bug Something isn't working invalid This doesn't seem right let you know isn't me labels Jun 6, 2024
@shreyash3087
Copy link
Contributor Author

@mdazfar2 alright i understood,i reverted back the team card as it was and modified the contributor card,can you verify again

@mdazfar2
Copy link
Owner

mdazfar2 commented Jun 6, 2024

@shreyash3087 Update the sync fork and update with git pull and then create pull request it is not changing on deployed link

@shreyash3087
Copy link
Contributor Author

@mdazfar2 i synced the fork for both the main as well as fix/team-card-alignment branch,and also did git pull,are the changes still not being reflected on vercel ? in that case what can i do?

@mdazfar2 mdazfar2 merged commit 3e64dd7 into mdazfar2:main Jun 6, 2024
3 checks passed
@mdazfar2 mdazfar2 added gssoc'24 level1 work done great work and removed bug Something isn't working invalid This doesn't seem right let you know isn't me labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Alignment of Team and Contributor Cards
2 participants