Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode #215

Closed
wants to merge 16 commits into from
Closed

Dark mode #215

wants to merge 16 commits into from

Conversation

Apurv7777
Copy link
Contributor

Fixes #175

Fully functional dark mode is applied. Please give level accordingly. 😊

Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
helpops-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 4:51am

Copy link

github-actions bot commented Jun 6, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@mdazfar2
Copy link
Owner

mdazfar2 commented Jun 6, 2024

@Apurv7777 It is not full dark mode on sides of Feedback


image


My expectation is-


image


  • @Apurv7777 can you integrate these all in only one page. Means when the user click dark mode it is enable all the pages. I will give lavel3 label for this.

@Apurv7777
Copy link
Contributor Author

I have an suggestion , if we make the color of button to gray, it seems like it is disabled. So, I suggest to not change the color of button.

@mdazfar2
Copy link
Owner

mdazfar2 commented Jun 6, 2024

@Apurv7777 It is merged by other issue could you please work on new issue; when the user clicks "dark mode icon" on "Homepage" it is enable all the pages. Means all of the pages will automatically dark.

@Apurv7777
Copy link
Contributor Author

@Apurv7777 It is merged by other issue could you please work on new issue; when the user clicks "dark mode icon" on "Homepage" it is enable all the pages. Means all of the pages will automatically dark.

It is done already in this PR.

@mdazfar2
Copy link
Owner

mdazfar2 commented Jun 6, 2024

@Apurv7777 It is merged by other issue could you please work on new issue; when the user clicks "dark mode icon" on "Homepage" it is enable all the pages. Means all of the pages will automatically dark.

It is done already in this PR.

Checkout the deployed link and use dark mode and see it enables on feedback section or not. Let me know fast

@Apurv7777
Copy link
Contributor Author

@Apurv7777 It is merged by other issue could you please work on new issue; when the user clicks "dark mode icon" on "Homepage" it is enable all the pages. Means all of the pages will automatically dark.

It is done already in this PR.

Checkout the deployed link and use dark mode and see it enables on feedback section or not. Let me know fast

I recommend you to merge this PR only for dark mode , because my implementation is simpler than the last dark mode fix and do think about this suggestion #215 (comment)

@Apurv7777
Copy link
Contributor Author

Apurv7777 commented Jun 6, 2024

And feedback page in my PR is also good enough , I think no changes are needed. Some colorfull elements makes the website beautiful.

@Apurv7777
Copy link
Contributor Author

Now, all your requested changes , along with my suggestion are resolved. @mdazfar2

@mdazfar2
Copy link
Owner

mdazfar2 commented Jun 6, 2024

What is this @Apurv7777 😶


image

@mdazfar2 mdazfar2 added bug Something isn't working wontfix This will not be worked on isn't me and removed let you know labels Jun 6, 2024
@mdazfar2 mdazfar2 closed this Jun 6, 2024
@Apurv7777
Copy link
Contributor Author

I will remove that icon.

@Apurv7777
Copy link
Contributor Author

Apurv7777 commented Jun 6, 2024

image

It is perfect in my localhost. @mdazfar2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working isn't me wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark Mode Issue
2 participants