-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode #215
Dark mode #215
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
@Apurv7777 It is not full dark mode on sides of FeedbackMy expectation is-
|
I have an suggestion , if we make the color of button to gray, it seems like it is disabled. So, I suggest to not change the color of button. |
@Apurv7777 It is merged by other issue could you please work on new issue; when the user clicks "dark mode icon" on "Homepage" it is enable all the pages. Means all of the pages will automatically dark. |
It is done already in this PR. |
Checkout the deployed link and use dark mode and see it enables on feedback section or not. Let me know fast |
I recommend you to merge this PR only for dark mode , because my implementation is simpler than the last dark mode fix and do think about this suggestion #215 (comment) |
And feedback page in my PR is also good enough , I think no changes are needed. Some colorfull elements makes the website beautiful. |
Now, all your requested changes , along with my suggestion are resolved. @mdazfar2 |
What is this @Apurv7777 😶 |
I will remove that icon. |
It is perfect in my localhost. @mdazfar2 |
Fixes #175
Fully functional dark mode is applied. Please give level accordingly. 😊