Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made the navbar attach to top and fixed feedback form #202

Closed

Conversation

Stiffpixels
Copy link

@Stiffpixels Stiffpixels commented Jun 5, 2024

All the features added and bugs fixed:

  1. Made the navbar stick to the top when scrolling down for easy navigation on.
  2. Made the navbar responsive for mobile and tablet.
2024-06-05.21-32-53.mp4
  1. Made the feedback form responsive on mobile.

image

Fixes issue #181

Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
helpops-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 3:45am

Copy link
Contributor

github-actions bot commented Jun 5, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@mdazfar2
Copy link
Owner

mdazfar2 commented Jun 5, 2024

@Stiffpixels You made the search icon really thin.

image

Here is the below our current search icon looks like-


image

  • Currenly search icon looks like attractive in case of you which you created pr.

@mdazfar2 mdazfar2 added no need thanks for issue but we already done it let you know pending this issue may be closed isn't me labels Jun 5, 2024
@Stiffpixels
Copy link
Author

@Stiffpixels You made the search icon really thin.

image

Here is the below our current search icon looks like-


image

  • Currenly search icon looks like attractive in case of you which you created pr.

Okay I will make the change

@Stiffpixels
Copy link
Author

@Stiffpixels You made the search icon really thin.

image

Here is the below our current search icon looks like-

image

* Currenly search icon looks like attractive in case of you which you created pr.

Done! also fixed the searchbar on tablet
current:
image

fixed:
image

@mdazfar2
Copy link
Owner

mdazfar2 commented Jun 6, 2024

@Stiffpixels please resolve conflict

@Stiffpixels
Copy link
Author

@mdazfar2 resolved all the conflicts

Copy link

netlify bot commented Jun 7, 2024

Deploy Preview for helpops-hub failed.

Name Link
🔨 Latest commit 119c790
🔍 Latest deploy log https://app.netlify.com/sites/helpops-hub/deploys/666282569407540008d98b32

@Stiffpixels
Copy link
Author

@mdazfar2 please merge before more conflicts arise.

2024-06-07.09-14-46.mp4

Copy link
Contributor

This PR has been automatically closed due to inactivity from the owner for 15 days.

@github-actions github-actions bot added the Stale label Jun 23, 2024
@github-actions github-actions bot closed this Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflict isn't me let you know no need thanks for issue but we already done it pending this issue may be closed Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants