Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added logo with link and hover effect #197

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Conversation

Varsani2520
Copy link
Contributor

i added ,when user click on logo then redirect the home page
as well as add hover effect on the logo

BUG:redirect issue #188
close #188

@mdazfar2 ,check it and merged it

Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
helpops-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 3:03pm

Copy link
Contributor

github-actions bot commented Jun 5, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Varsani2520
Copy link
Contributor Author

@mdazfar2 ,also add the label as pr #188

Copy link
Owner

@mdazfar2 mdazfar2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Varsani2520 It has a bug. Instead of the Vercel link, please try to add index.html on the logo. It will be a problem in the future whenever I add a domain or try to host this with Hostinger or anything else.

@mdazfar2 mdazfar2 added bug Something isn't working wontfix This will not be worked on isn't me labels Jun 5, 2024
@Varsani2520
Copy link
Contributor Author

Hey @mdazfar2 ,
Official_Website/index.html
this is ok or /index.html

@mdazfar2
Copy link
Owner

mdazfar2 commented Jun 5, 2024

Hey @mdazfar2 , Official_Website/index.html this is ok or /index.html

@Varsani2520 Try it and see whether it is reducing as per your requirement

@Varsani2520
Copy link
Contributor Author

ok

@mdazfar2
Copy link
Owner

mdazfar2 commented Jun 5, 2024

@Varsani2520

  • & please don't forget to join our official Discord server so we can discuss more about HelpOps-Hub enhancement.
  • And also follow us on Linkedin

@Varsani2520
Copy link
Contributor Author

Hey @mdazfar2 ,i alreay do that

@Varsani2520
Copy link
Contributor Author

when i fork the project then in index.html ,
alreay link is available : <a href="https://helpops-hub.vercel.app/" ><img src="logo.png" alt="HelpOps-Hub Logo" /></a> and this is perfect so i can do in all page

tell me what's the issue that url

only that url redirect the home page

so we have no option for redirect

@Varsani2520
Copy link
Contributor Author

Hey @mdazfar2 ,
check it and merged it

i completed as you say
now it doesn't create any problem in add extra domain
please add level label

@mdazfar2
Copy link
Owner

mdazfar2 commented Jun 5, 2024

@Varsani2520 You are awesome

@mdazfar2 mdazfar2 added enhancement New feature or request gssoc'24 level2 web enhance try to make web impressive work done and removed bug Something isn't working wontfix This will not be worked on isn't me labels Jun 5, 2024
@mdazfar2 mdazfar2 merged commit d99a0f9 into mdazfar2:main Jun 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc'24 level2 web enhance try to make web impressive work done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG:redirect issue
2 participants