-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obsolete and replace terms 2 #28
Conversation
jamesaoverton
commented
Jun 17, 2024
•
edited
Loading
edited
- Add obsolete.tsv and dron-obsolete.owl
- Report on common problems, e.g. use of obsolete
- Use obsolete.tsv to replace terms
- Results of obsolete-and-replace for one ingredient
- Obsolete-and-replace DrOn ingredients with non-obsolete labels in ChEBI
- Obsolete-and-replace ~8000 DrOn terms where the pair of the label+RXCUI duplicates another DrOn term -- keep the DrOn term with the lowest ID number
@hoganwr When you have time, please start reviewing this PR. I suggest working through the commits in order. My next step is to obsolete about 8000 duplicate DrOn terms. |
After obsoleting the ~8000 DrOn terms with duplicate label+RxCUI pairs, I still have about 16 DrOn terms with duplicate labels but differing RxCUIs (some obsolete). I also have 668 duplicate RxCUIs in DrOn. Most seem to be obsolete or remapped by RxNorm. We'll discuss those on the next call. |
I have completed a build in commit 3af928b and it looks good. I have the build going on the subsequent commit. |
I'm up to commit 4e8a376 The new ChEBIs, which are referred to via term_replaced_by on obsoleted DrOn terms, are showing up at the top level. But I think that's easily fixed by updating the ChEBI import, and perhaps the subsequent commits accomplish that. I'm going to go ahead and move to the next commit. |
Ok, we'll be sure that's cleaned up before we commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've finished going through the commits one by one. Everything looks good.