Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete and replace terms 2 #28

Merged
merged 12 commits into from
Jul 17, 2024
Merged

Obsolete and replace terms 2 #28

merged 12 commits into from
Jul 17, 2024

Conversation

jamesaoverton
Copy link
Collaborator

@jamesaoverton jamesaoverton commented Jun 17, 2024

  • Add obsolete.tsv and dron-obsolete.owl
  • Report on common problems, e.g. use of obsolete
  • Use obsolete.tsv to replace terms
  • Results of obsolete-and-replace for one ingredient
  • Obsolete-and-replace DrOn ingredients with non-obsolete labels in ChEBI
  • Obsolete-and-replace ~8000 DrOn terms where the pair of the label+RXCUI duplicates another DrOn term -- keep the DrOn term with the lowest ID number

@jamesaoverton
Copy link
Collaborator Author

@hoganwr When you have time, please start reviewing this PR. I suggest working through the commits in order.

My next step is to obsolete about 8000 duplicate DrOn terms.

@jamesaoverton
Copy link
Collaborator Author

After obsoleting the ~8000 DrOn terms with duplicate label+RxCUI pairs, I still have about 16 DrOn terms with duplicate labels but differing RxCUIs (some obsolete). I also have 668 duplicate RxCUIs in DrOn. Most seem to be obsolete or remapped by RxNorm. We'll discuss those on the next call.

@hoganwr
Copy link
Collaborator

hoganwr commented Jun 18, 2024

I have completed a build in commit 3af928b and it looks good. I have the build going on the subsequent commit.

@hoganwr
Copy link
Collaborator

hoganwr commented Jun 21, 2024

I'm up to commit 4e8a376

The new ChEBIs, which are referred to via term_replaced_by on obsoleted DrOn terms, are showing up at the top level. But I think that's easily fixed by updating the ChEBI import, and perhaps the subsequent commits accomplish that.

I'm going to go ahead and move to the next commit.

@jamesaoverton
Copy link
Collaborator Author

The new ChEBIs, which are referred to via term_replaced_by on obsoleted DrOn terms, are showing up at the top level. But I think that's easily fixed by updating the ChEBI import, and perhaps the subsequent commits accomplish that.

Ok, we'll be sure that's cleaned up before we commit.

Copy link
Collaborator

@hoganwr hoganwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've finished going through the commits one by one. Everything looks good.

@jamesaoverton jamesaoverton marked this pull request as ready for review July 17, 2024 18:14
@jamesaoverton jamesaoverton merged commit 5742023 into main Jul 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants