zephyr: print version number before boot #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-nordic
reviewed
Jun 28, 2024
| @@ -536,6 +536,9 @@ int main(void) | |||
|
|
|||
| BOOT_LOG_INF("Bootloader chainload address offset: 0x%x", | |||
| rsp.br_image_off); | |||
| BOOT_LOG_INF("Image version: v%d.%d.%d", rsp.br_hdr->ih_ver.iv_major, | |||
There was a problem hiding this comment.
This should be configurable, because we start to take extra space with things that will be rarely viewed by anyone.
There was a problem hiding this comment.
I would imagine those concerned deeply about space will have logging off anyway. I'd hate to see yet another ifdef in the code just for this.
d3zd3z
approved these changes
Oct 10, 2024
|
Rebase needed |
Signed-off-by: Toon Stegen <[email protected]>
|
Rebased |
nordicjm
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before booting, It might be handy to see the version of the image we boot into.