Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(types): Return undefined too #6

Closed
wants to merge 2 commits into from
Closed

chore(types): Return undefined too #6

wants to merge 2 commits into from

Conversation

rozzilla
Copy link
Contributor

app, logger, request, reply can all be undefined (for instance if you don't run start). This PR adds types support for this scenario.

@mcollina
Copy link
Owner

I think it’s best if we make them throw instead.

@rozzilla
Copy link
Contributor Author

I think it’s best if we make them throw instead.

Yup, fair point 👉
It will make debugging easier, especially throwing clear Codes

@rozzilla
Copy link
Contributor Author

rozzilla commented Apr 23, 2024 •
edited
Loading

@mcollina something like this, right?

@rozzilla
Copy link
Contributor Author

rozzilla commented Apr 23, 2024 •
edited
Loading

We now either throw, or return them. So this change is no longer valid ;)

@rozzilla rozzilla closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rozzilla @mcollina