Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ts): Add types and TS documentation #2

Merged

Conversation

rozzilla
Copy link
Collaborator

As by title

@mcollina
Copy link
Owner

can you add a test for the types using tsd?

@rozzilla rozzilla force-pushed the feat/ts/add-types-and-ts-documentation branch from 87f7ea8 to 30e18a5 Compare April 20, 2024 22:10
@rozzilla rozzilla force-pushed the feat/ts/add-types-and-ts-documentation branch from 30e18a5 to ea2f928 Compare April 20, 2024 22:11
@rozzilla
Copy link
Collaborator Author

Done and added tsd @mcollina 😉

Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit f671e18 into mcollina:main Apr 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants