Redo XP perks #5095
Open
Redo XP perks #5095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I appreciate this PR but I'll have to think about if I merge this or not, you see I have a complete rewrite for perks in another branch that adds new functionality, I'd just have to port the code over... 😮💨 |
|
It would probably be better to either: A. Merge and fix this issue I don't think my solution is bad, or even hard to reverse if needed. But leaving this unpatched shouldn't really be considered? |
|
Good points, I'll think on it, and review the PR in the near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the old 'else if' chain used for xp perks and replaces it with an enum class for faster usage and other benefits. This PR also brings another important change by ensuring the highest XP multiplier amount is always used for the player.
Before this change, mcMMO would always use the custom multiplier if the player had permission for it even if it was lower than other multiplier amounts. This would cause conflicts for those who want to use the custom xp amount for a lower xp boost, and then give their players higher boost amounts later on.