Compatibility to tinyavr-1 #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed code formatting
|
Hi, thank you for your contribution. In your commit you have mixed a vast change of formatting with a change of functionality. The formatting certainly leaves room for improvement but for comparing changes this is a nightmare. Please split the functional and the formatting changes into two separate commits. After checking backwards compatibility I am happy to merge. Best regards, |
reverted formatting
|
Here you go. Have to admit that I haven't tested the rework with actual HW. |
fixed missing #endif in modbusInit
|
fixed 2 issues that slipped through and kept it from compiling. Sorry for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support and tested it with attiny816 and attiny1616.
Backwards-compatibility for "old" AVRs shouldn't be affected but wasn't tested (yet)