Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reading variable tab height for tab bounds #1832

Open
wants to merge 1 commit into
base: v5
Choose a base branch
from

Conversation

willhansen
Copy link

This branch allows for dragging tabs when using a non-uniform tab height, as mentioned in #1471

eg: If I want to apply this custom style, to let me read the full title of every tab, I currently can't properly click and drag tabs. As near as I can tell, this is due to tabs being assumed to be uniform height, and not reading from their dom elements. This branch fixes that.

Next step after this would probably be adding a display option rather than requiring custom css.

The custom style I'm applying:

Before After
image image
.Tab .body {
	border: 1px solid #c7c7c780;
}


#root {--tabs-height: auto !important;}
#root {--tabs-font-size: .8rem;}

.Tab .t-box {
  align-items: center;
  max-height: calc(var(--tabs-height) - var(--tabs-title-padding));
  overflow: hidden;
}


.Tab .title {
  font-size: var(--tabs-font-size);
	white-space: pre-wrap;
}


.Tab .close {
	width: 50px !important;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant