[fix] empty default value bug

mbknor · Jan 13, 2022 · 33cd268 · 33cd268
1 parent 78e7c18
commit 33cd268
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -163,7 +163,7 @@ Add this to you pom.xml:
     <dependency>
         <groupId>net.almson</groupId>
         <artifactId>mbknor-jackson-jsonschema-java</artifactId>
-        <version>1.0.39</version>
+        <version>1.0.39.1</version>
     </dependency>
 
 

diff --git a/pom.xml b/pom.xml
@@ -3,7 +3,7 @@
     <modelVersion>4.0.0</modelVersion>
     <groupId>net.almson</groupId>
     <artifactId>mbknor-jackson-jsonschema-java</artifactId>
-    <version>1.0.39</version>
+    <version>1.0.39.1</version>
     <packaging>jar</packaging>
 
     <description>mbknor-jackson-jsonSchema</description>

diff --git a/src/main/java/com/kjetland/jackson/jsonSchema/JsonSchemaGeneratorVisitor.java b/src/main/java/com/kjetland/jackson/jsonSchema/JsonSchemaGeneratorVisitor.java
@@ -56,7 +56,9 @@ String extractDefaultValue() {
 
         // Plain java
         var jp = tryGetAnnotation(JsonProperty.class);
-        if (jp != null)
+        if (jp != null 
+                && jp.defaultValue() != null
+                && !jp.defaultValue().isEmpty()) // unfortunately, defaultValue is empty by default
             return jp.defaultValue();
 
         var jsd = tryGetAnnotation(JsonSchemaDefault.class);