Add GHC 9.6 #286
Add GHC 9.6 #286
Conversation
epicallan
commented
Nov 14, 2023
•
epicallan
commented
- Stack fails to execute plugins with GHC 9.6 and for that reason, SourceConstraints is disabled on GHC 9.6 for now.
epicallan
force-pushed
the
change/upgrade-to-ghc-9.6
branch
10 times, most recently
from
44c0cd4 to
8918e12
Compare
There was a problem hiding this comment.
Comment: This golden test expectation file is suspiciously empty and I can't figure out why. I was expecting to see base, unliftio-core and text dependencies
There was a problem hiding this comment.
@epicallan mprelude is "wierd" as its a deep local dependency and is not registered to the stack.yaml like the others, you'll see this in extra-deps NOT packages.
You can try moving it to packages now as maybe stack is now smarter for "dependency trees" in packages.
There was a problem hiding this comment.
I moved it to packages and stack and seemed to have no trouble with its dependency tree resolutions. I will update PR with this change.
Update:
Further testing shows that dependency tree resolution is not yet smarter.
epicallan
force-pushed
the
change/upgrade-to-ghc-9.6
branch
2 times, most recently
from
47f47e3 to
f6eca7e
Compare
epicallan
force-pushed
the
change/upgrade-to-ghc-9.6
branch
from
18a78ae to
e244db1
Compare
| @@ -174,7 +174,6 @@ test-suite test | |||
| , mtl | |||
| , scientific | |||
| , should-not-typecheck | |||
| , source-constraints | |||
There was a problem hiding this comment.
@epicallan I do not see a common code change assocaited with this, commit scheduling error?
There was a problem hiding this comment.
So common/package.yaml already conditionally adds source-constraints as a dependence. This commit removes the duplicate addition of source-constraints via individual packages.yaml configs.
Maybe I should reword the commit to: Remove duplicate source-constraints dependency
There was a problem hiding this comment.
yes but the change to common/package.yaml is not on that commit?
There was a problem hiding this comment.
common/package.yaml already had source-constraints as a conditional dependency based on the development flag so there was no need to change it before this change.
The other change I make to common/package.yaml is to make source-constraints dependent on the GHC version. I don't believe that change needs to be part of this commit since it's a new change altogether.
epicallan
force-pushed
the
change/upgrade-to-ghc-9.6
branch
from
e244db1 to
683666a
Compare
|
@epicallan the git commit message uses |
epicallan
force-pushed
the
change/upgrade-to-ghc-9.6
branch
2 times, most recently
from
092dbfd to
5659c5d
Compare
aws-rds/aws-rds.cabal
Outdated
| else | ||
| ghc-options: -Wwarn | ||
| if impl(ghc < 9.6) |
There was a problem hiding this comment.
question: Is there a ghc 9.5? If so, would we want to run the code on it? Or should/can this be <= 9.4?
There was a problem hiding this comment.
Good catch. I have changed it to < 9.5 since <= 9.4 excludes 9.4 minor releases such as 9.4.7
* So common/package.yaml already conditionally adds source-constraints as a dependence. This commit removes the duplicate addition of source-constraints via individual packages.yaml configs.
* Stack fails to execute plugins with GHC 9.6 and therefore we disable SourceConstraints on GHC 9.6
epicallan
force-pushed
the
change/upgrade-to-ghc-9.6
branch
from
6dfd1be to
3d135db
Compare
