Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Use generated yaml directive for setup-config docs #106

Merged
merged 2 commits into from
Jan 27, 2025
Merged

📝 Use generated yaml directive for setup-config docs #106

merged 2 commits into from
Jan 27, 2025

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Jan 21, 2025 •
edited
Loading

@stevenbal stevenbal mentioned this pull request Jan 21, 2025
Merged
10 tasks
@stevenbal stevenbal marked this pull request as draft January 21, 2025 11:16
@stevenbal stevenbal force-pushed the feature/setup-config-docs branch 2 times, most recently from 5fc5148 to 369531a Compare January 21, 2025 11:31
@stevenbal stevenbal force-pushed the feature/setup-config-docs branch 5 times, most recently from 8912ca8 to a648305 Compare January 23, 2025 09:40
@stevenbal stevenbal marked this pull request as ready for review January 23, 2025 09:40
swrichards
swrichards requested changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just a few suggestions for rephrasing.

zgw_consumers/contrib/setup_configuration/models.py Outdated Show resolved Hide resolved
zgw_consumers/contrib/setup_configuration/steps.py Outdated Show resolved Hide resolved
zgw_consumers/contrib/setup_configuration/models.py Outdated Show resolved Hide resolved
zgw_consumers/contrib/setup_configuration/models.py Outdated Show resolved Hide resolved
zgw_consumers/models/services.py Outdated Show resolved Hide resolved
zgw_consumers/models/services.py Outdated Show resolved Hide resolved
docs/setup_config.rst Outdated Show resolved Hide resolved
@stevenbal
📝 Use generated yaml directive for setup-config docs
419e02e 
and add missing help texts for Service model
@stevenbal stevenbal force-pushed the feature/setup-config-docs branch from a648305 to 419e02e Compare January 23, 2025 11:06
@stevenbal stevenbal requested a review from swrichards January 23, 2025 11:06
@stevenbal stevenbal merged commit 54246e7 into main Jan 27, 2025
7 checks passed
@stevenbal stevenbal deleted the feature/setup-config-docs branch January 27, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swrichards swrichards swrichards approved these changes

@sergei-maertens sergei-maertens Awaiting requested review from sergei-maertens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenbal @swrichards