fix string field max lengths

maykinmedia · Jan 31, 2025 · f11e4e7 · f11e4e7
1 parent a40617d
commit f11e4e7
Show file tree

Hide file tree

Showing 13 changed files with 425 additions and 274 deletions.
diff --git a/src/open_producten/fixtures/default_admin_index.json b/src/open_producten/fixtures/default_admin_index.json
diff --git a/...roducten/locaties/migrations/0004_alter_locatie_huisnummer_alter_locatie_naam_and_more.py b/...roducten/locaties/migrations/0004_alter_locatie_huisnummer_alter_locatie_naam_and_more.py
@@ -0,0 +1,75 @@
+# Generated by Django 4.2.17 on 2025-01-31 13:34
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("locaties", "0003_organisatie_code"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="locatie",
+            name="huisnummer",
+            field=models.CharField(
+                blank=True, max_length=10, null=True, verbose_name="huisnummer"
+            ),
+        ),
+        migrations.AlterField(
+            model_name="locatie",
+            name="naam",
+            field=models.CharField(max_length=255, verbose_name="naam"),
+        ),
+        migrations.AlterField(
+            model_name="locatie",
+            name="stad",
+            field=models.CharField(
+                blank=True, max_length=255, null=True, verbose_name="stad"
+            ),
+        ),
+        migrations.AlterField(
+            model_name="locatie",
+            name="straat",
+            field=models.CharField(
+                blank=True, max_length=255, null=True, verbose_name="straat"
+            ),
+        ),
+        migrations.AlterField(
+            model_name="organisatie",
+            name="code",
+            field=models.CharField(
+                help_text="code van de organisatie.",
+                max_length=255,
+                unique=True,
+                verbose_name="code",
+            ),
+        ),
+        migrations.AlterField(
+            model_name="organisatie",
+            name="huisnummer",
+            field=models.CharField(
+                blank=True, max_length=10, null=True, verbose_name="huisnummer"
+            ),
+        ),
+        migrations.AlterField(
+            model_name="organisatie",
+            name="naam",
+            field=models.CharField(max_length=255, verbose_name="naam"),
+        ),
+        migrations.AlterField(
+            model_name="organisatie",
+            name="stad",
+            field=models.CharField(
+                blank=True, max_length=255, null=True, verbose_name="stad"
+            ),
+        ),
+        migrations.AlterField(
+            model_name="organisatie",
+            name="straat",
+            field=models.CharField(
+                blank=True, max_length=255, null=True, verbose_name="straat"
+            ),
+        ),
+    ]
diff --git a/src/open_producten/locaties/models/locatie.py b/src/open_producten/locaties/models/locatie.py
@@ -8,7 +8,7 @@
 class BaseLocatie(BaseModel):
     naam = models.CharField(
         verbose_name=_("naam"),
-        max_length=100,
+        max_length=255,
     )
     email = models.EmailField(
         verbose_name=_("email adres"),
@@ -23,12 +23,12 @@ class BaseLocatie(BaseModel):
         validators=[validate_phone_number],
     )
 
-    straat = models.CharField(_("straat"), null=True, blank=True, max_length=250)
+    straat = models.CharField(_("straat"), null=True, blank=True, max_length=255)
     huisnummer = models.CharField(
         _("huisnummer"),
         blank=True,
         null=True,
-        max_length=250,
+        max_length=10,
     )
 
     postcode = models.CharField(
@@ -40,7 +40,7 @@ class BaseLocatie(BaseModel):
     )
     stad = models.CharField(
         _("stad"),
-        max_length=250,
+        max_length=255,
         blank=True,
         null=True,
     )

diff --git a/src/open_producten/locaties/models/organisatie.py b/src/open_producten/locaties/models/organisatie.py
@@ -11,7 +11,7 @@ class Meta:
 
     code = models.CharField(
         verbose_name=_("code"),
-        max_length=100,
+        max_length=255,
         help_text=_("code van de organisatie."),
         unique=True,
     )

diff --git a/...roducten/producttypen/migrations/0013_alter_contentlabel_naam_alter_link_naam_and_more.py b/...roducten/producttypen/migrations/0013_alter_contentlabel_naam_alter_link_naam_and_more.py
@@ -0,0 +1,89 @@
+# Generated by Django 4.2.17 on 2025-01-31 13:34
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("producttypen", "0012_delete_vraag"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="contentlabel",
+            name="naam",
+            field=models.CharField(max_length=255, unique=True),
+        ),
+        migrations.AlterField(
+            model_name="link",
+            name="naam",
+            field=models.CharField(
+                help_text="Naam van de link.", max_length=255, verbose_name="naam"
+            ),
+        ),
+        migrations.AlterField(
+            model_name="prijsoptie",
+            name="beschrijving",
+            field=models.CharField(
+                help_text="Korte beschrijving van de optie.",
+                max_length=255,
+                verbose_name="beschrijving",
+            ),
+        ),
+        migrations.AlterField(
+            model_name="producttype",
+            name="code",
+            field=models.CharField(
+                help_text="code van het product type.",
+                max_length=255,
+                unique=True,
+                verbose_name="code",
+            ),
+        ),
+        migrations.AlterField(
+            model_name="producttypetranslation",
+            name="naam",
+            field=models.CharField(
+                help_text="naam van het product type.",
+                max_length=255,
+                verbose_name="product type naam",
+            ),
+        ),
+        migrations.AlterField(
+            model_name="producttypetranslation",
+            name="samenvatting",
+            field=models.TextField(
+                default="",
+                help_text="Korte samenvatting van het product type.",
+                verbose_name="samenvatting",
+            ),
+        ),
+        migrations.AlterField(
+            model_name="thema",
+            name="beschrijving",
+            field=models.TextField(
+                blank=True,
+                default="",
+                help_text="Beschrijving van het thema, ondersteund markdown format.",
+                verbose_name="beschrijving",
+            ),
+        ),
+        migrations.AlterField(
+            model_name="thema",
+            name="naam",
+            field=models.CharField(
+                help_text="Naam van het thema.", max_length=255, verbose_name="naam"
+            ),
+        ),
+        migrations.AlterField(
+            model_name="uniformeproductnaam",
+            name="naam",
+            field=models.CharField(
+                help_text="Uniforme product naam",
+                max_length=255,
+                unique=True,
+                verbose_name="naam",
+            ),
+        ),
+    ]
diff --git a/src/open_producten/producttypen/models/content.py b/src/open_producten/producttypen/models/content.py
@@ -9,7 +9,7 @@
 
 
 class ContentLabel(BaseModel):
-    naam = models.CharField(max_length=100, unique=True)
+    naam = models.CharField(max_length=255, unique=True)
 
     def __str__(self):
         return self.naam

diff --git a/src/open_producten/producttypen/models/link.py b/src/open_producten/producttypen/models/link.py
@@ -15,7 +15,7 @@ class Link(BaseModel):
         help_text=_("Het product type waarbij deze link hoort."),
     )
     naam = models.CharField(
-        verbose_name=_("naam"), max_length=100, help_text=_("Naam van de link.")
+        verbose_name=_("naam"), max_length=255, help_text=_("Naam van de link.")
     )
     url = models.URLField(verbose_name=_("Url"), help_text=_("Url van de link."))
 

diff --git a/src/open_producten/producttypen/models/prijs.py b/src/open_producten/producttypen/models/prijs.py
@@ -50,7 +50,7 @@ class PrijsOptie(BaseModel):
     )
     beschrijving = models.CharField(
         verbose_name=_("beschrijving"),
-        max_length=100,
+        max_length=255,
         help_text=_("Korte beschrijving van de optie."),
     )
 

diff --git a/src/open_producten/producttypen/models/producttype.py b/src/open_producten/producttypen/models/producttype.py
@@ -29,7 +29,7 @@ class ProductType(BasePublishableModel, TranslatableModel):
 
     code = models.CharField(
         verbose_name=_("code"),
-        max_length=100,
+        max_length=255,
         help_text=_("code van het product type."),
         unique=True,
     )
@@ -112,14 +112,11 @@ class ProductType(BasePublishableModel, TranslatableModel):
         samenvatting=models.TextField(
             verbose_name=_("samenvatting"),
             default="",
-            max_length=300,
-            help_text=_(
-                "Korte beschrijving van het product type, maximaal 300 karakters."
-            ),
+            help_text=_("Korte samenvatting van het product type."),
         ),
         naam=models.CharField(
             verbose_name=_("product type naam"),
-            max_length=100,
+            max_length=255,
             help_text=_("naam van het product type."),
         ),
     )

diff --git a/src/open_producten/producttypen/models/thema.py b/src/open_producten/producttypen/models/thema.py
@@ -2,15 +2,13 @@
 from django.db import models
 from django.utils.translation import gettext_lazy as _
 
-from markdownx.models import MarkdownxField
-
 from open_producten.utils.models import BasePublishableModel
 
 
 class Thema(BasePublishableModel):
 
     naam = models.CharField(
-        verbose_name=_("naam"), max_length=100, help_text=_("Naam van het thema.")
+        verbose_name=_("naam"), max_length=255, help_text=_("Naam van het thema.")
     )
 
     hoofd_thema = models.ForeignKey(
@@ -23,7 +21,7 @@ class Thema(BasePublishableModel):
         on_delete=models.PROTECT,
     )
 
-    beschrijving = MarkdownxField(
+    beschrijving = models.TextField(
         verbose_name=_("beschrijving"),
         blank=True,
         default="",

diff --git a/src/open_producten/producttypen/models/upn.py b/src/open_producten/producttypen/models/upn.py
@@ -7,7 +7,7 @@
 class UniformeProductNaam(BaseModel):
     naam = models.CharField(
         verbose_name=_("naam"),
-        max_length=100,
+        max_length=255,
         help_text=_("Uniforme product naam"),
         unique=True,
     )

diff --git a/src/open_producten/producttypen/serializers/content.py b/src/open_producten/producttypen/serializers/content.py
@@ -16,9 +16,9 @@ class ContentElementSerializer(TranslatableModelSerializer):
         required=False,
     )
 
-    content = serializers.CharField(
+    content = serializers.CharField(  # TODO CHARFIELD?????
         required=True,
-        max_length=100,
+        max_length=255,
         help_text=_("De content van dit content element."),
     )
 
@@ -68,7 +68,6 @@ class NestedContentElementSerializer(serializers.ModelSerializer):
 
     content = serializers.CharField(
         required=True,
-        max_length=100,
         help_text=_("De content van dit content element."),
     )
 
@@ -84,7 +83,6 @@ class Meta:
 class ContentElementTranslationSerializer(serializers.ModelSerializer):
     content = serializers.CharField(
         required=True,
-        max_length=100,
         help_text=_("De content van dit content element."),
     )
 

diff --git a/src/open_producten/producttypen/serializers/producttype.py b/src/open_producten/producttypen/serializers/producttype.py
@@ -92,11 +92,10 @@ class ProductTypeSerializer(TranslatableModelSerializer):
     )
 
     naam = serializers.CharField(
-        required=True, max_length=100, help_text=_("naam van het product type.")
+        required=True, max_length=255, help_text=_("naam van het product type.")
     )
     samenvatting = serializers.CharField(
         required=True,
-        max_length=300,
         help_text=_("Korte beschrijving van het product type."),
     )
 
@@ -189,11 +188,10 @@ class Meta:
 class ProductTypeTranslationSerializer(serializers.ModelSerializer):
 
     naam = serializers.CharField(
-        required=True, max_length=100, help_text=_("naam van het product type.")
+        required=True, max_length=255, help_text=_("naam van het product type.")
     )
     samenvatting = serializers.CharField(
         required=True,
-        max_length=300,
         help_text=_("Korte beschrijving van het product type."),
     )