-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [#2665] Fix phone-parsing Safari (iOS only) #1369
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1369 +/- ##
===========================================
- Coverage 94.23% 94.21% -0.02%
===========================================
Files 1068 1074 +6
Lines 39348 39621 +273
===========================================
+ Hits 37080 37330 +250
- Misses 2268 2291 +23 ☔ View full report in Codecov by Sentry. |
b7c6a77
to
0a866a3
Compare
0756b0d
to
d761b2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestion for the new CSS class name, otherwise looking good. Browserstack is currently not working for me, I'll need to try again to test this.
@@ -62,4 +62,14 @@ | |||
display: inline; | |||
} | |||
} | |||
|
|||
// Remove Safari iOS phone-parsing from specific elements | |||
.phone-parsing { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.phone-parsing { | |
.skip-phone-parsing { |
or something like it so that the function of the class is clear from the name alone (otherwise you have to come hear to look at the comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yeah, good one, will do.
pointer-events: none; | ||
} | ||
// Hide style for iOS-rendered anchor element | ||
.phone-parsing > a { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.phone-parsing > a { | |
.skip-phone-parsing > a { |
pointer-events: none; | ||
} | ||
|
||
.phone-parsing > a { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.phone-parsing > a { | |
.skip-phone-parsing > a { |
@@ -260,6 +260,17 @@ strong .color--primary, strong .color--secondary { | |||
border-top: 3px solid #999999; | |||
} | |||
|
|||
/* iOS specific */ | |||
|
|||
.phone-parsing { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.phone-parsing { | |
.skip-phone-parsing { |
ff37634
to
e4277c1
Compare
@pi-sigma Actually I was not able to replicate this problem in Browserstack. Meaning: if I keep the meta-tag in the Master template as is |
155e080
to
2bcc9a0
Compare
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2665
The turn-numbers-into-phone-links feature should be disabled with the format-detection meta-tag, but... on every Safari and iOS update this breaks again 😡; many users on new devices report the meta tag does not solve the problem, so we need to create a hack with pointer-events is zero and add a zero-width joiner
‍
to make the numbers unrecognizable.I've also added these to the Zaaknummers e-mail templates, since those are also parsed in iOS.
While I was reproducing all this in Browserstack I found a bug in the skip-link specific for Safari only, which is also solved here.