Skip to content

Commit

Permalink
saving paperless approval for later, we may switch this on soon
Browse files Browse the repository at this point in the history
  • Loading branch information
adRn-s committed Nov 2, 2023
1 parent ca23995 commit 6eec13b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<!-- DISABLED FEATURE: - Added a 'Solicite approval via e-mail' context menu option for sequencing requests that belong users with both their own and their pi's email address at `settings.EMAIL_HOST` (that means, we can rely on the email spoofing as in the 'compose email' menu that staff users already had). -->

??.??.??
========

Expand All @@ -24,7 +26,6 @@ Non-breaking changes:
- Rule `import-pgdb` now brings migration files (to reproduce database schema) by default (if available).
- The `<URL>/api/samples/<id>` doesn't fail anymore if no `pk` was given.
- Added an EmailField to PrincipalInvestigator. This field is used in the 'paperless approval' feature (see next point.)
- Added a 'Solicite approval via e-mail' context menu option for sequencing requests that belong users with both their own and their pi's email address at `settings.EMAIL_HOST` (that means, we can rely on the email spoofing as in the 'compose email' menu that staff users already had).
- Added new endpoint, `<URL>/api/requests/<id>/get_poolpaths/`, returns a dictionary with records' barcode as keys and pool names as values.

23.09.20
Expand Down
2 changes: 1 addition & 1 deletion parkour_app/common/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def can_solicite_paperless_approval(self):
and self.email.split("@")[1] == settings.EMAIL_HOST
):
result_user = True
return result_user and result_pi
return False # TODO: switch hardcoded value for result_user and result_pi

def __str__(self):
this_user_email = self.email
Expand Down

0 comments on commit 6eec13b

Please sign in to comment.