Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor model classes and provide to_dict method #160

Merged
merged 7 commits into from
Jan 17, 2025
Merged

Refactor model classes and provide to_dict method #160

merged 7 commits into from
Jan 17, 2025

Conversation

oschwald
Copy link
Member

  • Update OS and Python version
  • Specify Sphinx configuration
  • Replace NamedTuple subclasses for model code
  • Pass in locales as a normal parameter
  • Add to_dict method to models for serialization

@oschwald oschwald force-pushed the greg/eng-841-easy-way-to-serialize-python-minfraud-model-objects-to-json branch 2 times, most recently from bb61796 to 9f891f5 Compare January 16, 2025 23:46
@oschwald oschwald force-pushed the greg/eng-841-easy-way-to-serialize-python-minfraud-model-objects-to-json branch from 9f891f5 to bab9464 Compare January 16, 2025 23:50
@oschwald
Move removal of empty values to to_dict
83ca8f8 
This will make the dict more similar to the original response.
@oschwald
Remove deprecate attribute
431c616
@oschwald oschwald force-pushed the greg/eng-841-easy-way-to-serialize-python-minfraud-model-objects-to-json branch from 6bd16e6 to 431c616 Compare January 17, 2025 15:21
@horgh horgh merged commit 0468503 into main Jan 17, 2025
36 checks passed
@horgh horgh deleted the greg/eng-841-easy-way-to-serialize-python-minfraud-model-objects-to-json branch January 17, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@horgh horgh horgh approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oschwald @horgh