Skip to content

Commit

Permalink
Check address for null
Browse files Browse the repository at this point in the history
  • Loading branch information
marselester committed Feb 16, 2024
1 parent d39000c commit 45fb776
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
18 changes: 9 additions & 9 deletions HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -11,30 +11,30 @@ History
* ``pxp_financial``
* ``trustpay``

* Equivalent domain names are now normalized when ``hash_address`` is used.
* Equivalent domain names are now normalized when ``hash_email`` is used.
For example, ``googlemail.com`` will become ``gmail.com``.
* Periods are now removed from ``gmail.com`` email address local parts when
``hash_address`` is used. For example, ``[email protected]`` will become
``hash_email`` is used. For example, ``[email protected]`` will become
``[email protected]``.
* Fastmail alias subdomain email addresses are now normalized when
``hash_address`` is used. For example, ``[email protected]`` will
``hash_email`` is used. For example, ``[email protected]`` will
become ``[email protected]``.
* Additional ``yahoo.com`` email addresses now have aliases removed from
their local part when ``hash_address`` is used. For example,
their local part when ``hash_email`` is used. For example,
``[email protected]`` will become ``[email protected]`` for additional
``yahoo.com`` domains.
* Duplicate ``.com`` s are now removed from email domain names when
``hash_address`` is used. For example, ``example.com.com`` will become
``hash_email`` is used. For example, ``example.com.com`` will become
``example.com``.
* Extraneous characters after ``.com`` are now removed from email domain
names when ``hash_address`` is used. For example, ``example.comfoo`` will
names when ``hash_email`` is used. For example, ``example.comfoo`` will
become ``example.com``.
* Certain ``.com`` typos are now normalized to ``.com`` when ``hash_address`` is
* Certain ``.com`` typos are now normalized to ``.com`` when ``hash_email`` is
used. For example, ``example.cam`` will become ``example.com``.
* Additional ``gmail.com`` domain names with leading digits are now
normalized when ``hash_address`` is used. For example, ``100gmail.com`` will
normalized when ``hash_email`` is used. For example, ``100gmail.com`` will
become ``gmail.com``.
* Additional ``gmail.com`` typos are now normalized when ``hash_address`` is
* Additional ``gmail.com`` typos are now normalized when ``hash_email`` is
used. For example, ``gmali.com`` will become ``gmail.com``.

2.9.0 (2023-12-05)
Expand Down
2 changes: 1 addition & 1 deletion minfraud/request.py
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ def maybe_hash_email(transaction):
return

address, domain = _clean_email(address)
if not address:
if address is None:
return

if domain != "" and "domain" not in email:
Expand Down

0 comments on commit 45fb776

Please sign in to comment.