Add delegated identity API support to spire-api package #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eitan Yarmush <[email protected]>
Signed-off-by: Eitan Yarmush <[email protected]>
maxlambrecht
requested changes
Aug 14, 2023
| @@ -15,10 +15,25 @@ categories = ["cryptography"] | |||
| keywords = ["SPIFFE", "SPIRE"] | |||
|
|
|||
| [dependencies] | |||
| spiffe = { version = "0.3.1", path = "../spiffe" } | |||
| bytes = { version = "1", features = ["serde"] } | |||
| spiffe = { path = "../spiffe" } | |||
There was a problem hiding this comment.
Considering that the crates in this repository will be versioned independently, it would be prudent to pin the spiffe dependency to a specific version when publishing the spire-api crate. This ensures that anyone using a published version of the spire-api crate will receive a consistent and known-good version of the spiffe crate. By explicitly specifying the version, we maintain control over the compatibility of the dependencies.
| /// * An error occurs while setting up the stream. | ||
| /// | ||
| /// Individual stream items might also be errors if there's an issue processing the response for a specific update. | ||
| pub async fn stream_x509_svids( |
There was a problem hiding this comment.
I like this name for the streaming method. 👌
| &spiffe::spiffe_id::TrustDomain::new("example.org".as_ref()) | ||
| .expect("Failed to parse trust domain ="), | ||
| ) | ||
| .expect("Failed to get bundle"); | ||
| } |
There was a problem hiding this comment.
There should be tests exercising the streaming methods.
EItanya
force-pushed
the
feature/delegated-identity-spire-api
branch
2 times, most recently
from
55456ec
to
e2e4e50
Compare
Signed-off-by: Eitan Yarmush <[email protected]>
EItanya
force-pushed
the
feature/delegated-identity-spire-api
branch
from
e2e4e50
to
274781a
Compare
maxlambrecht
added a commit
that referenced
this pull request
Aug 21, 2023
* Refactor repository: new `spiffe` folder, new `spire-api` crate, and `spire-api-sdk` submodule (#42) Signed-off-by: Max Lambrecht <[email protected]> * Add delegated identity API support to spire-api package (#43) Signed-off-by: Eitan Yarmush <[email protected]> * Refactoring `spiffe` crate: Introducing `spiffe-types` and `workload-api` features (#44) Signed-off-by: Max Lambrecht <[email protected]> * Add Releasing Process Documentation for Crates (#45) Signed-off-by: Max Lambrecht <[email protected]> --------- Signed-off-by: Max Lambrecht <[email protected]> Co-authored-by: Eitan Yarmush <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.