Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid setting avatar_url to "" #171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid setting avatar_url to "" #171

wants to merge 1 commit into from

Commits on Apr 30, 2024

  1. Avoid setting avatar_url to "" 

    Fixes an edge-case bug where calling `set_avatar_url("")` when the user
doesn't have an avatar(`get_avatar_url()` returns `None`) caused a
redundant PUT request to be made to nullify the already-empty avatar_url
field in the user profile. This also fixes the errant `$user made no
change` state events appearing in every room they are in when
`set_avatar_url("")` is called.

Signed-off-by: Joe Groocock <[email protected]>
    @frebib
    frebib committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    4ef121c View commit details
    Browse the repository at this point in the history