metrics: add option metrics.addr for ipv6 support
#168
Conversation
Counterpart to mautrix/python#168
`prometheus_client` supports IPv6 addresses for a while now[1]. This isn't used here however because the default 0.0.0.0 is used. Added an option `metrics.addr` that makes this configurable. [1] prometheus/client_python@39d2360
|
cc @tulir :) |
| @@ -188,6 +188,7 @@ def start_prometheus(self) -> None: | |||
| try: | |||
| enabled = self.config["metrics.enabled"] | |||
| listen_port = self.config["metrics.listen_port"] | |||
| addr = self.config.get("metrics.addr", "0.0.0.0") | |||
There was a problem hiding this comment.
Since we are using these values here, I think we need to have corresponding copys in mautrix/bridge/config.py. See https://github.com/mautrix/twitter/blob/master/mautrix_twitter/config.py#L48-L49 for an example of what it should look like.
There was a problem hiding this comment.
oh right, didn't notice because I think I don't use that part.
Will update accordingly later:)
There was a problem hiding this comment.
@sumnerevans OK, I confused a few things when I read your comment, apologies!
I already did that for the bridge I've been using, namely mautrix/telegram#955. In fact, I'm already using that productively, so this code is not untested :)
Do you want me to file fixup PRs for the other python bridges or is it OK for you to update when bumping mautrix/python there? If so, are all bridges to update in this org?
There was a problem hiding this comment.
Not sure what should be done here, @tulir ?
prometheus_clientsupports IPv6 addresses for a while now[1]. This isn't used here however because the default 0.0.0.0 is used. Added an optionmetrics.addrthat makes this configurable.Tested with mautrix-telegram.
[1] prometheus/client_python@39d2360