Skip to content

Commit

Permalink
fix: better mocks for tests
Browse files Browse the repository at this point in the history 
improvement: use structure instead of array for getPendingKomments (may fix #64)
  • Loading branch information
@mauricerenck
mauricerenck committed Jan 22, 2024
1 parent 9631367 commit 1160be6
Show file tree
Hide file tree
Showing 7 changed files with 463 additions and 71 deletions.
8 changes: 8 additions & 0 deletions site/blueprints/pages/phpunit.yml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
options:
changeSlug: false
update: true

sections:
phpunit:
komments:
extends: sections/komments
276 changes: 256 additions & 20 deletions tests/base/UtilsBaseTest.php
View file
Original file line number Diff line number Diff line change
@@ -1,10 +1,20 @@
<?php

namespace mauricerenck\Komments;

use mauricerenck\Komments\KommentBaseUtils;
use PHPUnit\Framework\TestCase;
use Kirby\Cms;
use mauricerenck\Komments\TestCaseMocked;


final class UtilsBaseTest extends TestCase
final class UtilsBaseTest extends TestCaseMocked
{

public function setUp(): void
{
parent::setUp();
}


public function testShouldHandleUnkownPage()
{
$baseUtils = new KommentBaseUtils();
Expand Down Expand Up @@ -54,40 +64,266 @@ public function testShouldHaveDifferentKommentTypes()
$this->assertEquals(100, $pendingComments[2]['spamlevel']);
}

public function testNeverExpireByDefault()
// public function testNeverExpireByDefault()
// {
// $pageMock = $this->getMockBuilder(Page::class)
// ->enableProxyingToOriginalMethods();

// $baseUtils = new KommentBaseUtils();
// $this->assertEquals(0, $baseUtils->kommentsAreExpired($pageMock));
// }

// public function testShouldNotBeExpired()
// {
// $pageMock = $this->getMockBuilder(Page::class)
// ->enableProxyingToOriginalMethods();

// c::set('mauricerenck.komments.auto-disable-komments', 10);
// $baseUtils = new KommentBaseUtils();
// $this->assertEquals(0, $baseUtils->kommentsAreExpired($pageMock));
// }

// public function testReturnCommentCount()
// {
// $pageMock = $this->getMockBuilder(Page::class)
// ->enableProxyingToOriginalMethods();

// $baseUtils = new KommentBaseUtils();
// $this->assertEquals(3, $baseUtils->getPendingCommentCount());
// }

// public function testReturnSpamCommentCount()
// {
// $pageMock = $this->getMockBuilder(Page::class)
// ->enableProxyingToOriginalMethods();

// $baseUtils = new KommentBaseUtils();
// $this->assertEquals(1, $baseUtils->getSpamCommentCount());
// }

/**
* @group panel
* @testdox getCommentsOfPage - should get 3 comments
*/
public function testGetCommentsOfPage()
{
$pageMock = $this->getPageMock();
$baseUtils = new KommentBaseUtils();

$expectedResult = [
[
'id' => '1bfffa3f189b3c5b5d6f3ed3271d3342',
'slug' => 'phpunit-test',
'author' => 'Unknown user',
'authorUrl' => '',
'komment' => '<p>A regular comment of an unkown user</p>',
'kommentType' => 'KOMMENT',
'image' => 'https://www.gravatar.com/avatar/c67cfe10182e385fcd4181c06334a527',
'title' => 'phpunit-test',
'url' => '/panel/pages/phpunit-test',
'published' => '2021-11-10 13:50',
'verified' => false,
'spamlevel' => 0,
'status' => false
],
[
'id' => 'c62bc1426c1d39eb6d8a6b4f5b3ef3ee',
'slug' => 'phpunit-test',
'author' => 'Verified User',
'authorUrl' => 'https://maurice-renck.de',
'komment' => '<p>A regular comment of a verified user</p>',
'kommentType' => 'KOMMENT',
'image' => 'https://www.gravatar.com/avatar/8b77c0a84579af62f82da07d9abedf56',
'title' => 'phpunit-test',
'url' => '/panel/pages/phpunit-test',
'published' => '2021-11-10 13:50',
'verified' => true,
'spamlevel' => 0,
'status' => true
],
[
'id' => '594a3bdc4947c1a8496d2beb8a065cb1',
'slug' => 'phpunit-test',
'author' => 'SpamBot',
'authorUrl' => '',
'komment' => '<p>A spam comment by an evil bot</p>',
'kommentType' => 'KOMMENT',
'image' => 'https://www.gravatar.com/avatar/fa5d3b1755664ea7cb3c8ef1e00a5a52',
'title' => 'phpunit-test',
'url' => '/panel/pages/phpunit-test',
'published' => '2021-11-10 13:50',
'verified' => false,
'spamlevel' => 100,
'status' => false
],
];

$result = $baseUtils->getCommentsOfPage($pageMock);
$this->assertEquals($result, $expectedResult);
}


/**
* @group panel
* @testdox getCommentsOfPage - should get 2 pending comments, no public
*/
public function testGetCommentsOfPageNoPublic()
{
$pageMock = $this->getMockBuilder(Page::class)
->enableProxyingToOriginalMethods();
$pageMock = $this->getPageMock(false, [
'kommentsInbox' => '
-
author: Unknown user
avatar: >
https://www.gravatar.com/avatar/c67cfe10182e385fcd4181c06334a527
authorurl: ""
authoremail: ""
kommenttype: KOMMENT
quote: ""
komment: A regular comment of an unkown user
source: https://komments.test:8890/phpunit
target: https://komments.test:8890/phpunit
mentionof: https://komments.test:8890/phpunit
property: KOMMENT
published: 2021-11-10 13:50:00
status: "true"
verified: "false"
id: 1bfffa3f189b3c5b5d6f3ed3271d3342
spamlevel: 0
-
author: Verified User
avatar: >
https://www.gravatar.com/avatar/8b77c0a84579af62f82da07d9abedf56
authorurl: https://maurice-renck.de
authoremail: ""
kommenttype: KOMMENT
quote: ""
komment: A regular comment of a verified user
source: https://komments.test:8890/phpunit
target: https://komments.test:8890/phpunit
mentionof: https://komments.test:8890/phpunit
property: KOMMENT
published: 2021-11-10 13:50:00
status: "false"
verified: "true"
id: c62bc1426c1d39eb6d8a6b4f5b3ef3ee
spamlevel: 0
-
author: SpamBot
avatar: >
https://www.gravatar.com/avatar/fa5d3b1755664ea7cb3c8ef1e00a5a52
authorurl: ""
authoremail: ""
kommenttype: KOMMENT
quote: ""
komment: A spam comment by an evil bot
source: https://komments.test:8890/phpunit
target: https://komments.test:8890/phpunit
mentionof: https://komments.test:8890/phpunit
property: KOMMENT
published: 2021-11-10 13:50:00
status: "false"
verified: "false"
id: 594a3bdc4947c1a8496d2beb8a065cb1
spamlevel: 100'
]);

$expectedResult = [
[
'id' => 'c62bc1426c1d39eb6d8a6b4f5b3ef3ee',
'slug' => 'phpunit-test',
'author' => 'Verified User',
'authorUrl' => 'https://maurice-renck.de',
'komment' => '<p>A regular comment of a verified user</p>',
'kommentType' => 'KOMMENT',
'image' => 'https://www.gravatar.com/avatar/8b77c0a84579af62f82da07d9abedf56',
'title' => 'phpunit-test',
'url' => '/panel/pages/phpunit-test',
'published' => '2021-11-10 13:50',
'verified' => true,
'spamlevel' => 0,
'status' => false
],
[
'id' => '594a3bdc4947c1a8496d2beb8a065cb1',
'slug' => 'phpunit-test',
'author' => 'SpamBot',
'authorUrl' => '',
'komment' => '<p>A spam comment by an evil bot</p>',
'kommentType' => 'KOMMENT',
'image' => 'https://www.gravatar.com/avatar/fa5d3b1755664ea7cb3c8ef1e00a5a52',
'title' => 'phpunit-test',
'url' => '/panel/pages/phpunit-test',
'published' => '2021-11-10 13:50',
'verified' => false,
'spamlevel' => 100,
'status' => false
],
];

$baseUtils = new KommentBaseUtils();
$this->assertEquals(0, $baseUtils->kommentsAreExpired($pageMock));
$result = $baseUtils->getCommentsOfPage($pageMock, 'pending');

$this->assertEquals($result, $expectedResult);
$this->assertCount(2, $result);
}

public function testShouldNotBeExpired()
/**
* @group panel
* @testdox getCommentsOfPage - should get 1 spam comment
*/
public function testGetCommentsOfPageOnlySpam()
{
$pageMock = $this->getMockBuilder(Page::class)
->enableProxyingToOriginalMethods();
$pageMock = $this->getPageMock();
$expectedResult = [
[
'id' => '594a3bdc4947c1a8496d2beb8a065cb1',
'slug' => 'phpunit-test',
'author' => 'SpamBot',
'authorUrl' => '',
'komment' => '<p>A spam comment by an evil bot</p>',
'kommentType' => 'KOMMENT',
'image' => 'https://www.gravatar.com/avatar/fa5d3b1755664ea7cb3c8ef1e00a5a52',
'title' => 'phpunit-test',
'url' => '/panel/pages/phpunit-test',
'published' => '2021-11-10 13:50',
'verified' => false,
'spamlevel' => 100,
'status' => false
],
];

c::set('mauricerenck.komments.auto-disable-komments', 10);
$baseUtils = new KommentBaseUtils();
$this->assertEquals(0, $baseUtils->kommentsAreExpired($pageMock));
$result = $baseUtils->getCommentsOfPage($pageMock, 'spam');

$this->assertEquals($result, $expectedResult);
$this->assertCount(1, $result);
}

public function testReturnCommentCount()
/**
* @group panel
* @testdox getCommentsCountOfPage - should get 2 comments
*/
public function testGetPendingCommentsCount()
{
$pageMock = $this->getMockBuilder(Page::class)
->enableProxyingToOriginalMethods();
$pageMock = $this->getPageMock();

$baseUtils = new KommentBaseUtils();
$this->assertEquals(3, $baseUtils->getPendingCommentCount());
$result = $baseUtils->getCommentsCountOfPage($pageMock, 'pending');

$this->assertEquals(2, $result);
}

public function testReturnSpamCommentCount()
/**
* @group panel
* @testdox getCommentsCountOfPage - should get 1 spam comment
*/
public function testGetSpamCommentsCount()
{
$pageMock = $this->getMockBuilder(Page::class)
->enableProxyingToOriginalMethods();
$pageMock = $this->getPageMock();

$baseUtils = new KommentBaseUtils();
$this->assertEquals(1, $baseUtils->getSpamCommentCount());
$result = $baseUtils->getCommentsCountOfPage($pageMock, 'spam');

$this->assertEquals(1, $result);
}
}
Loading

0 comments on commit 1160be6

Please sign in to comment.