Fix for issue 41 - change Map to unknown #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feature makes sense, and I like it! Please add a readme, and some more tests to ensure that the current behaviour of Map is unaffected. |
|
I added only more tests for now but in the last one, TS marked I'm not sure why. |
|
Could you pull in |
|
I did what you asked for. Unfortunately without the expected result. I still have a TS underlined map.clear(). |
|
@pnowak Apologies for the length of time to merge this PR. Great contribution, thanks so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this idea - #41 is taken into account, so I didn't complete the readme file.
I could update the readme if this feature will be accepted.