Add support for checkins/resolve endpoint #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[fix mattmueller#101] Now clients can get an information about a checkin by a short ID at the end of a swarmapp.com url like: ``` client.resolve_checkin(shortId: 'dcBOk2Awmpj') ```
|
Hi @mattmueller, could you please look at this? Thanks |
|
Hello @mattmueller, @marcomoura, @acmeyer, @R-obert could you guys somebody review and merge this PR? Thanks! |
marcomoura
reviewed
Oct 29, 2018
| req.url "checkins/resolve", options | ||
| end | ||
| return_error_or_body(response, response.body.response.checkin) | ||
| end |
lib/foursquare2.rb
Outdated
| @@ -39,6 +39,7 @@ def configure | |||
| require 'foursquare2/pages' | |||
| require 'foursquare2/lists' | |||
| require 'foursquare2/events' | |||
| require 'foursquare2/multi' | |||
There was a problem hiding this comment.
I saw another PR with this change, would be better to let this to be merged there... wdyt to extract from this PR the commit and the code related to the 'multi'?
|
Hi @marcomoura, I removed the code related to the 'multi' PR. Can you merge it now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[fix #101]
Now clients can get an information about a checkin by a short ID at the
end of a swarmapp.com url like: