Set deepest nested service to current #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so that we always use the deepest nested service as the `current`. This is not a breaking change as this is current expected behavior. We were passing `service.child` to be the new current, but not accounting for the possibility of deeply nested machines. Fixes #195
🦋 Changeset detectedLatest commit: 20e68d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ehuelsmann
reviewed
Dec 27, 2024
| @@ -359,7 +359,7 @@ QUnit.module('Invoke', hooks => { | |||
|
|
|||
| QUnit.test('Invoking a machine that immediately finishes', async assert => { | |||
| assert.expect(3); | |||
| const expectations = [ 'two', 'nestedTwo', 'three' ]; | |||
| const expectations = [ 'nestedTwo', 'three', 'three' ]; | |||
There was a problem hiding this comment.
Agreed that this is the expected behaviour. For the next breaking (major) release, I'd say that it makes a lot of sense to have const expectations = [ 'two.nestedTwo', 'three', 'three' ]; because it aligns with the recently added .matches() API.
There was a problem hiding this comment.
Should we collect these somewhere?
ehuelsmann
reviewed
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that we always use the deepest nested service as the
current.This is not a breaking change as this is current expected behavior. We were passing
service.childto be the new current, but not accounting for the possibility of deeply nested machines.Fixes #195