Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable unused-parameter golangci check #191

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

mickmister
Copy link
Contributor

Summary

Ticket Link

@mickmister mickmister requested a review from hanzei November 20, 2023 02:26
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (846ffb5) 5.26% compared to head (1d4529a) 5.26%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #191   +/-   ##
======================================
  Coverage    5.26%   5.26%           
======================================
  Files           3       3           
  Lines          38      38           
======================================
  Hits            2       2           
  Misses         36      36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mickmister mickmister merged commit 376ea7e into master Nov 20, 2023
4 checks passed
@mickmister mickmister deleted the disable-unused-parameter-lint branch November 20, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants