Ingress deletion by label instead of name #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kaiivoschneider: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. I understand the commands that are listed here |
mm-cloud-bot
added
do-not-merge/release-note-label-needed
release-note-none
fmartingr
reviewed
Nov 29, 2023
| LabelSelector: labels.SelectorFromSet(labelSet), | ||
| }) | ||
|
|
||
| if err != nil && len(foundIngresses.Items) > 0 { | ||
| return nil | ||
| } else if err != nil { | ||
| return errors.Wrap(err, "failed to check if ingress exists") | ||
| } |
There was a problem hiding this comment.
Since only one result is expected, should we handle and raise an error if the list retrieves more than one result or should we remove all results? cc: @mattermost/cloud
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Mattermost operator keeps deleting Ingresses it did not create itself if they have the same name. It makes more sense for the operator to find resources by their labels. That is what Kubernetes labels are for.
Release Note