Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Note on usage of .nvmrc in plugin projects #1321

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

Rutam21
Copy link
Contributor

@Rutam21 Rutam21 commented Dec 14, 2023

Summary

This PR adds a basic Tip at the end of the Plugins Overview page that guides the user on how to use .nvmrc in plugin projects.

Ticket Link

Fixes #1222

This PR adds a basic Tip at the end of the Plugins Overview page that guides the user on how to use .nvmrc in plugin projects.
@mattermost-build
Copy link
Contributor

Hello @Rutam21,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@Rutam21
Copy link
Contributor Author

Rutam21 commented Dec 14, 2023

Please review and suggest changes, if any. Thanks.

cc: @cwarnermm @mickmister

@cwarnermm cwarnermm added 1: Dev Review Requires review by a core commiter 2: Editor Review Requires review by an editor labels Dec 14, 2023
Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @Rutam21!

@mickmister
Copy link
Contributor

mickmister commented Dec 15, 2023

Related PR #1320

@cwarnermm cwarnermm added 4: Reviews Complete All reviewers have approved the pull request and removed 1: Dev Review Requires review by a core commiter 2: Editor Review Requires review by an editor labels Dec 15, 2023
@cwarnermm cwarnermm merged commit 352b49e into mattermost:master Dec 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help Wanted: Document usage of .nvmrc in plugin projects
4 participants