[MM-62241] Fix screen sharing from Calls popout window #3258
Conversation
streamer45
added
2: Dev Review
| @@ -362,6 +362,12 @@ describe('main/windows/callsWidgetWindow', () => { | |||
| urlUtils.isCallsPopOutURL.mockReturnValue(false); | |||
| expect(callsWidgetWindow.onPopOutOpen({url: 'http://localhost:8065/notpopouturl'})).toHaveProperty('action', 'deny'); | |||
| }); | |||
|
|
|||
| it('should pop out and make sure preload is set', () => { | |||
|
@DHaussermann You should be familiar with this since you hit it before while testing unrelated changes. |
|
/update-brach |
|
@DHaussermann Updated |
|
@DHaussermann Can we prioritize QA review on this? Need to cut the RC on Monday. |
|
@devinbinnie Yes, happy to make this a priority. Perhaps you can assist? I tried testing this yesterday and can't get a Mac build to install.
When I unzip the build for ARM64 and try to launch it Mac OS tells me the app is damaged. Is there another way to do this? I feel like this ☝️ is exactly what I did in the past for desktop PRs |
|
@DHaussermann You need to add the "Build Apps for PR" label, that creates a signed app that you should be able to run. I've added it for you and you should be able to grab the build from the check when it is finished building. |
|
Thanks @devinbinnie I may have tried the label in the past at some point but was not sure where the build would be posted. Taking a look now on Community the Desktop Builds channel does not show any new posts for a couple days. https://community.mattermost.com/core/channels/desktop-builds Do they get posted elsewhere? |
|
@DHaussermann They're in the artifacts for the GitHub Action: https://github.com/mattermost/desktop/actions/runs/12831481292 |
|
@streamer45 I don't see this issue solved.
Can you please advice if you can repro this? |
Summary
As of #3174, some of the functionality in the Calls popout window (e.g. screen sharing) stopped working since
desktopAPIis missing on the window object. Using the local preload seems to be the way to go.Since we are here, I am also adding an extra dynamic menu item to access the developer tools of the popout, which can be helpful in debugging future issues like this one.
/cc @matthewbirtch
Ticket Link
https://mattermost.atlassian.net/browse/MM-62241
Release Note