-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update release process with release-please #549
ci: update release process with release-please #549
Conversation
da93b4a
to
7db8cb0
Compare
7db8cb0
to
452459d
Compare
@antonbaliasnikov were you able to test successfully in a fork by any chance? I suppose this will also Closes #474 |
@dutterbutter , I've tested it in this PR by enabling In the fork, I've tested But I will test a bit more as I found see some issues with
But we need to discuss minor details with you and @itegulov about the flow. Because |
17b8157
to
d6b0e58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because release-please will always create the release first, and only then we start jobs to add binaries and publish docker images. We can re-try them if they fail, but anyway it would be nice to discuss the flow we would like to see.
Can't we make release-please create preleases where the corresponding docker tag would be prerelease-vx.y.z
and then once we ensure everything is buildable/pushable, we promote prerelease that triggers retagging from prelease-vx.y.z
to vx.y.z
which should be infallible?
That being said I don't want to complicate the flow too much so I think it is fine to leave it as is if there are no reasonable options. Let's just make sure that job failures are visible, I don't want them to be "swallowed" silently. I am guessing at least the person who pressed the merge button on the PR would get an email notification about job failure, correct?
d6b0e58
to
84541b3
Compare
Prereleases are barely supported with For now, yes, visibility will be highly better and email notifications + Slack notifications about failures should be sent. |
@itegulov , please, take another look. I fixed all issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left a small nit but feel free to merge as is
|
||
concurrency: | ||
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | ||
cancel-in-progress: true | ||
cancel-in-progress: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: do we even need concurrency groups anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I guess it can be removed in this case.
What 💻
release-please
configuration and workflows