System search bar

[Nidoxs]

Proposed changes

Adds a search bar to the client debugger view. Systems are hidden when they do not match the search filter.

Related issues

Closes #109

Additional comments

The server debugger would also benefit greatly from the search feature but the way that's all setup makes it more complicated. Let's re-visit another time to add the search to the server view.

Preview

https://gyazo.com/509ee4478fa14ac37a1b7ad642b128df

[jackTabsCode]

I'm not sure it makes sense to add it to one realm but not the other

[Nidoxs]

I'm not sure it makes sense to add it to one realm but not the other

I do agree that it is peculiar to add it to one realm and not the other. The shared server debugger complicates implementing the search feature, but I'm happy to explore that again with guidance.

[LastTalon]

but the way that's all setup makes it more complicated.

Can you explain in more detail exactly what is making it more complicated and how much more complicated?

[Nidoxs]

Do we share the search filter between users or do we come up with a way to allow users to search independently from each other?

[LastTalon]

Do we share the search filter between users or do we come up with a way to allow users to search independently from each other?

Right now the there's just one server debugger, so it doesn't really seem like that's much different from other parts of the state that get shared for everyone using it unless I'm misunderstanding something.

[Nidoxs]

but the way that's all setup makes it more complicated.

Can you explain in more detail exactly what is making it more complicated and how much more complicated?

The server debugger is setup in a way that shares the debugger state between debugging clients. The EventBridge class seems to handle parts of that behaviour. I was unsure on how best to approach implementing it, as following the existing shared behaviour of the server debugger would mean that the search filter is shared between debugging clients. Essentially, if multiple clients were typing in the server search bar at the same time, their search filters would be clashing with each other.

I could have another look at some point to see if making the search on the server unique to the client who is searching is feasible with the current setup. I'm not yet well familiarized with the shared server debugger's logic (the part of it that shares the state between all debugger clients), so that may be why I found it less straightforward.

[Nidoxs]

I did try adding a updateSearchFilter condition case here, but there's more to it than that.

[LastTalon]

as following the existing shared behaviour of the server debugger would mean that the search filter is shared between debugging clients.

Right, this is what I'm saying. This doesn't sound like new behavior or a new challenge to me, it sounds like it's just baggage we already deal with in the server debugger because of the way it works. There's lots of state that's sort of weird because of how it operates in this shared way, and this just sounds like another.

We can improve it, but I think it's just okay to have it work that way for now, and we can look into improving it later. Honestly, most of the time only one person is really using the debugger at a time anyway. So it's a bit of unpleasantness sometimes, but not something that I think really should prevent it from functioning.

If you think you have a good handle on the problem you can go ahead and pre-emptively make an issue for it, but I think we should have this working in the server debugger even if it behaves weird when that happens.

[Nidoxs]

I'll take a look at the server search functionality again! 😄

[jackTabsCode]

@Nidoxs Why is this closed? I think that it's currently OK to have shared state between client and server in the debugger because that's how the rest of this works.