refactor(crypto)!: Remove unused OneTimeKey::Key and SessionCreationError::OneTimeKeyUnknown variants

[zecakeh]

As discussed in #4171 (comment).

[poljar]

Looks good, though the commit mentions that OneTimeKey::Signed was removed, no such variant exists and SignedKey certainly was not removed.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.91%. Comparing base (71abbeb) to head (190fb3f).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...rates/matrix-sdk-crypto/src/types/one_time_keys.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4194      +/-   ##
==========================================
+ Coverage   84.89%   84.91%   +0.02%     
==========================================
  Files         272      272              
  Lines       29142    29131      -11     
==========================================
- Hits        24739    24738       -1     
+ Misses       4403     4393      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zecakeh]

Oops, sorry about that. It's fixed now.

[andybalaam]

This contained some crypto interface changes (https://github.com/matrix-org/matrix-rust-sdk-crypto-wasm/actions/runs/11604714936/job/32313920920) that would have been helpful to document in the changelog

[andybalaam]

This contained some crypto interface changes (matrix-org/matrix-rust-sdk-crypto-wasm/actions/runs/11604714936/job/32313920920) that would have been helpful to document in the changelog

No blame though - it's almost impossible to keep track of this and the automated checks we have are after-the-fact, which is how I'm picking it up.

[poljar]

This contained some crypto interface changes (https://github.com/matrix-org/matrix-rust-sdk-crypto-wasm/actions/runs/11604714936/job/32313920920) that would have been helpful to document in the changelog

Err, but we're using git-cliff for changelogs and this commit is even marked to contain a breaking change.

[poljar]

To clarify a bit further, every time you bump the SDK version in the WASM bindings you can use git cliff $commit..range to get the list of relevant changes. So no need to manually look through the CHANGELOG.md file and guestimate what was part of your bump or not.

Of course all of this might become even easier once we start doing releases, hopefully next week.

[andybalaam]

Ah, so I should not have expected it to appear in CHANGELOG.md yet? Thanks, I didn't realise git-cliff was going to do this job for crypto stuff.

Of course all of this might become even easier once we start doing releases, hopefully next week.

🚀

[poljar]

Ah, so I should not have expected it to appear in CHANGELOG.md yet?

That's correct, the changelog will be updated during the release, it'll be a bit of a mess the first time we do this since we have a mix of cliff entries and hand written entries but eventually things will stabilize.