Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk: add support for listening to stream of live location updates #4025

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

torrybr
Copy link
Contributor

@torrybr torrybr commented Sep 22, 2024

Conversation related to this issue can be found here

This merge request adds subscribe_to_live_location_shares to the matrix_sdk::Room that allows clients to listen for beacon updates using a background task. The method provides an easy way to subscribe to live location sharing events within a room, handling event processing internally.

Follow-up tasks will include adding support for the event cache.

@torrybr torrybr requested a review from a team as a code owner September 22, 2024 15:36
@torrybr torrybr requested review from bnjbvr and removed request for a team September 22, 2024 15:36
@torrybr torrybr changed the title Add Support for listening to stream of live location updates sdk: add support for listening to stream of live location updates Sep 22, 2024
@bnjbvr bnjbvr requested review from a team and stefanceriu and removed request for bnjbvr and a team September 23, 2024 07:49
@stefanceriu
Copy link
Member

Seems that the test aren't particularly happy with this PR. Can you please have a look?

Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I've left some feedback that can impact the global design of your patch.

crates/matrix-sdk/src/room/mod.rs Outdated Show resolved Hide resolved
crates/matrix-sdk/src/room/mod.rs Outdated Show resolved Hide resolved
crates/matrix-sdk/src/room/mod.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.85%. Comparing base (8865e2f) to head (7f2d7a6).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/matrix-sdk/src/room/mod.rs 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4025      +/-   ##
==========================================
- Coverage   84.89%   84.85%   -0.05%     
==========================================
  Files         272      272              
  Lines       29167    29187      +20     
==========================================
+ Hits        24761    24766       +5     
- Misses       4406     4421      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@torrybr torrybr requested a review from Hywan September 24, 2024 15:10
crates/matrix-sdk/src/live_location.rs Outdated Show resolved Hide resolved
crates/matrix-sdk/src/live_location.rs Outdated Show resolved Hide resolved
crates/matrix-sdk/src/live_location.rs Outdated Show resolved Hide resolved
crates/matrix-sdk/src/room/mod.rs Show resolved Hide resolved
crates/matrix-sdk/src/room/mod.rs Outdated Show resolved Hide resolved
crates/matrix-sdk/src/room/mod.rs Show resolved Hide resolved
crates/matrix-sdk/tests/integration/room/beacon/mod.rs Outdated Show resolved Hide resolved
@stefanceriu stefanceriu removed their request for review September 24, 2024 15:17
@torrybr torrybr requested a review from Hywan September 24, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants