-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdk: add support for listening to stream of live location updates #4025
base: main
Are you sure you want to change the base?
Conversation
Seems that the test aren't particularly happy with this PR. Can you please have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I've left some feedback that can impact the global design of your patch.
3b574dd
to
7066fb3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4025 +/- ##
==========================================
- Coverage 84.89% 84.85% -0.05%
==========================================
Files 272 272
Lines 29167 29187 +20
==========================================
+ Hits 24761 24766 +5
- Misses 4406 4421 +15 ☔ View full report in Codecov by Sentry. |
2012753
to
c5ec943
Compare
Signed-off-by: torrybr <[email protected]>
Conversation related to this issue can be found here
This merge request adds
subscribe_to_live_location_shares
to thematrix_sdk::Room
that allows clients to listen for beacon updates using a background task. The method provides an easy way to subscribe to live location sharing events within a room, handling event processing internally.Follow-up tasks will include adding support for the event cache.