Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy crypto files #4672

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Jan 31, 2025

Task element-hq/element-web#26922
Part of #4653

This PR:

  • removes the legacy crypto (except legacy crypto stores which are needed for the migration from the legacy crypto to the rust crypto)
  • removes the legacy crypto unit tests
  • makes the CI happy:
    • Remove unused types
    • Fix typedoc broken link
    • I had to remove the {@link} tag in files where typedoc isn't able to resolve the CryptoApi link:
      [warning] Failed to resolve link to "CryptoApi.getUserDeviceInfo" in comment for matrix.Device.
      I tried without success to keep the {@link} tag.

@florianduros florianduros marked this pull request as ready for review February 3, 2025 10:15
@florianduros florianduros requested review from a team as code owners February 3, 2025 10:15
@florianduros florianduros requested review from andybalaam, BillCarsonFr and dbkr and removed request for a team February 3, 2025 10:15
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

@florianduros florianduros merged commit 6bd319b into florianduros/rip-out-legacy-crypto/remove-legacy-crypto Feb 3, 2025
31 checks passed
@florianduros florianduros deleted the florianduros/rip-out-legacy-crypto/remove-crypto-files branch February 3, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants