Skip to content

Commit

Permalink
Pin the Node minor version for Docker builds (#949)
Browse files Browse the repository at this point in the history
* Pin the Node minor version for Docker builds

as 20.13 & 20.14 cause Hookshot to crash on startup (at least on arm64)

* Add changelog
  • Loading branch information
AndrewFerr authored Jun 21, 2024
1 parent 5dae23b commit 5c5e8ce
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Stage 0: Build the thing
# Need debian based image to build the native rust module
# as musl doesn't support cdylib
FROM node:20-slim AS builder
FROM node:20.12-slim AS builder

# Needed in order to build rust FFI bindings.
RUN apt-get update && apt-get install -y build-essential cmake curl pkg-config pkg-config libssl-dev
Expand Down Expand Up @@ -29,7 +29,7 @@ RUN yarn build


# Stage 1: The actual container
FROM node:20-slim
FROM node:20.12-slim

WORKDIR /bin/matrix-hookshot

Expand Down
1 change: 1 addition & 0 deletions changelog.d/949.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Pin the minor version of Node for Docker builds to avoid a startup crash on arm64.

0 comments on commit 5c5e8ce

Please sign in to comment.