Fix: leave should not execute kick as user can't kick itself. #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We introduced this as a way to leave with a reason, because it at least used to be the case that you can always kick yourself (which at a high level is the same as leaving, just with the option to leave a departing message). These days the spec supports leaving with a reason, so we should allow that. |
Half-Shot
approved these changes
May 2, 2023
Co-authored-by: Will Hunt <[email protected]>
Signed-off-by: iwalkalone <[email protected]>
…service-bridge into fix-intent-leave
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user leaves an IRC channel this should execute leaveRoom instead of kickUser even if it has a reason. Otherwise it fails because user has no permission to kick himself.