This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Add support to GIPHY bot for downsampled images #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kegsay
reviewed
Apr 8, 2020
| @@ -67,7 +67,7 @@ services: | |||
| UserID: "@goneb:localhost" # requires a Syncing client | |||
| Config: | |||
| api_key: "qwg4672vsuyfsfe" | |||
| use_downsized: false | |||
| image_type: 0 | |||
There was a problem hiding this comment.
I'd prefer string enums to integers as strings are more descriptive without knowing the mapping.
kegsay
approved these changes
Apr 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #217 , adding support for fixed_height_downsampled and fixed_width_downsampled images as per the GIPHY API to provide the option of reducing GIF file size further. Replaces use_downsized with image_type to support all four image types (original image, fixed height downsampled, fixed width downsampled, and downsized).
I'm relatively new to contributing to open source projects so if there is anything I could improve upon I am welcome to feedback, thank you!
Signed-off-by: William Pine [email protected]