Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves engine detection for DuckDuckGo Privacy Browser, Phoenix Browser and Yandex Browser #7709

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Improves engine detection for DuckDuckGo Privacy Browser, Phoenix Browser and Yandex Browser #7709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8bb486d
Remove default engine for Phoenix Browser
liviuconcioiu Jun 11, 2024
f0544d5
Remove default engine for DuckDuckGo Privacy Browser
liviuconcioiu Jun 11, 2024
74fe2db
Improve regex for Yandex Browser
liviuconcioiu Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions Tests/Parser/Client/fixtures/browser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9433,3 +9433,30 @@
engine: ""
engine_version: ""
family: ""
-
user_agent: Mozilla/5.0 (iPhone; CPU iPhone OS 12_5_7 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) PHX/13.3
client:
type: browser
name: Phoenix Browser
version: "13.3"
engine: WebKit
engine_version: 605.1.15
family: Chrome
-
user_agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.4 DuckDuckGo/7 Safari/605.1.15
client:
type: browser
name: DuckDuckGo Privacy Browser
version: "7"
engine: WebKit
engine_version: 605.1.15
family: Chrome
-
user_agent: Mozilla/5.0 (iPhone; CPU iPhone OS 17_4 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.0 YaBrowser/24.4.5.383.10 SA/3 Mobile/15E148 Safari/604.1
client:
type: browser
name: Yandex Browser
version: 24.4.5.383.10
engine: WebKit
engine_version: 605.1.15
family: ""
10 changes: 6 additions & 4 deletions regexes/client/browsers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,8 +1078,6 @@
- regex: 'PHX/(?:(\d+[\.\d]+))?'
name: 'Phoenix Browser'
version: '$1'
engine:
default: 'Blink'

# PrivacyWall (https://play.google.com/store/apps/details?id=org.privacywall.browser)
- regex: 'PrivacyWall/(?:(\d+[\.\d]+))?'
Expand Down Expand Up @@ -2205,7 +2203,7 @@
version: '$1'
engine:
default: 'WebKit'
- regex: 'iP(?:hone|ad);.+YaBrowser(?:/(\d+[\.\d]*)) Mobile'
- regex: 'iP(?:hone|ad).*YaBrowser(?:/(\d+[\.\d]*))'
name: 'Yandex Browser'
version: '$1'
engine:
Expand Down Expand Up @@ -2379,7 +2377,11 @@
versions:
28: 'Blink'

- regex: '(?:DDG-Android-|DuckDuckGo/|ddg_android/)(\d+[\.\d]*)'
# DuckDuckGo Privacy Browser
- regex: 'DuckDuckGo/(\d+[\.\d]*)'
name: 'DuckDuckGo Privacy Browser'
version: '$1'
- regex: '(?:DDG-Android-|ddg_android/)(\d+[\.\d]*)'
name: 'DuckDuckGo Privacy Browser'
version: '$1'
engine:
Expand Down
Loading