Skip to content

Commit

Permalink
Adds detection for NOOK Browser (#7687)
Browse files Browse the repository at this point in the history
* Adds detection for NOOK Browser
  • Loading branch information
liviuconcioiu authored May 21, 2024
1 parent cdd8a82 commit c0bbe10
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Parser/Client/Browser.php
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,7 @@ class Browser extends AbstractClientParser
'N2' => 'Norton Private Browser',
'NX' => 'Nox Browser',
'N1' => 'NOMone VR Browser',
'N6' => 'NOOK Browser',
'NE' => 'NetSurf',
'NF' => 'NetFront',
'NL' => 'NetFront Life',
Expand Down Expand Up @@ -761,7 +762,7 @@ class Browser extends AbstractClientParser
'H5', 'V3', 'G2', 'BG', 'OL', 'II', 'TL', 'M6', 'Y3',
'M7', 'GN', 'D3', 'IG', 'HW', '4O', 'OU', '5P', 'KE',
'5A', 'TT', '6P', 'G3', '7P', 'VU', 'F8', 'L4', 'DK',
'DP', 'KL', 'K4',
'DP', 'KL', 'K4', 'N6',
];

/**
Expand Down
9 changes: 9 additions & 0 deletions Tests/Parser/Client/fixtures/browser.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9406,3 +9406,12 @@
engine: ""
engine_version: ""
family: ""
-
user_agent: nook browser/1.0
client:
type: browser
name: NOOK Browser
version: "1.0"
engine: ""
engine_version: ""
family: ""
5 changes: 5 additions & 0 deletions regexes/client/browsers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@
# @license http://www.gnu.org/licenses/lgpl.html LGPL v3 or later
###############

# NOOK Browser
- regex: 'nook browser(?:/(\d+[\.\d]+))?'
name: 'NOOK Browser'
version: '$1'

# Arachne (https://www.glennmcc.org/)
- regex: 'xChaos_Arachne/5\.(\d+\.[\.\d]+)'
name: 'Arachne'
Expand Down

0 comments on commit c0bbe10

Please sign in to comment.