Skip to content

Commit

Permalink
Adds detection for Gmail and Spicebird (#7712)
Browse files Browse the repository at this point in the history
* Adds detection for Spicebird
* Improves detection for Spice brand
* Adds detection for Gmail
  • Loading branch information
liviuconcioiu authored Jun 21, 2024
1 parent 668b5f6 commit a2bdee7
Show file tree
Hide file tree
Showing 4 changed files with 39 additions and 1 deletion.
12 changes: 12 additions & 0 deletions Tests/Parser/Client/fixtures/pim.yml
Original file line number Diff line number Diff line change
Expand Up @@ -275,3 +275,15 @@
type: pim
name: mailapp
version: 6.5.0
-
user_agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.2pre) Gecko/2009031304 Spicebird/0.7.1
client:
type: pim
name: Spicebird
version: 0.7.1
-
user_agent: Android-Gmail/64562652 (sw411dp; 420dpi) (r7 TP1A.220624.014)
client:
type: pim
name: Gmail
version: ""
16 changes: 16 additions & 0 deletions Tests/fixtures/desktop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9727,3 +9727,19 @@
model: Engage One Pro AIO
os_family: Android
browser_family: Chrome
-
user_agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.2pre) Gecko/2009031304 Spicebird/0.7.1
os:
name: GNU/Linux
version: ""
platform: x86
client:
type: pim
name: Spicebird
version: 0.7.1
device:
type: desktop
brand: ""
model: ""
os_family: GNU/Linux
browser_family: Unknown
10 changes: 10 additions & 0 deletions regexes/client/pim.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@
name: 'Thunderbird'
version: '$1'

# Spicebird (http://www.spicebird.org/)
- regex: 'Spicebird/(\d+\.[\.\d]+)'
name: 'Spicebird'
version: '$1'

- regex: 'Airmail(?: (\d+[\.\d]+))?'
name: 'Airmail'
version: '$1'
Expand Down Expand Up @@ -155,3 +160,8 @@
- regex: 'mailapp/(\d+\.[\.\d]+)'
name: 'mailapp'
version: '$1'

# Gmail
- regex: 'Android-Gmail'
name: 'Gmail'
version: ''
2 changes: 1 addition & 1 deletion regexes/device/mobiles.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23793,7 +23793,7 @@ Sigma:

# Spice
Spice:
regex: '(?<![\d];)Spice|(?:Xlife[-_ ](?:\d+Q?|Victor5|M5q\+|M5 Pro|Proton5|Electro55HD))(?:[);/ ]|$)'
regex: '(?<![\d];)Spice(?!bird)|(?:Xlife[-_ ](?:\d+Q?|Victor5|M5q\+|M5 Pro|Proton5|Electro55HD))(?:[);/ ]|$)'
device: 'smartphone'
models:
- regex: '(?:Spice_)?Xlife[-_ ](\d+Q?|M5\+)(?:[);/ ]|$)'
Expand Down

0 comments on commit a2bdee7

Please sign in to comment.