Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expo-config-plugin): rework expo-config-plugin to fix lateinit error #77

Closed
wants to merge 1 commit into from

Conversation

xseignard
Copy link

@xseignard xseignard commented Mar 25, 2024

Updated the expo-config-plugin to handle:

  • Android 13 and lower with an activity triggered by androidx.health.ACTION_SHOW_PERMISSIONS_RATIONALE intent
  • Android 14 with an activity-alias triggered by android.intent.action.VIEW_PERMISSION_USAGE intent
  • The activity code is to be provided by users
  • Updated docs

Tested on expo 49/java MainActivity & expo 50/kotlin MainActivity

Fixes #71

@matinzd
Copy link
Owner

matinzd commented Mar 26, 2024

Hey!

Thanks for the contribution and helping with the expo plugin. I will review it as soon as I find some time.

@matinzd matinzd self-assigned this Mar 26, 2024
@xseignard
Copy link
Author

Hello @brentvatne
Thanks for your review. I clearly think migrating this library to expo modules is out of scope of this PR

@brentvatne
Copy link

Hello @brentvatne Thanks for your review. I clearly think migrating this library to expo modules is out of scope of this PR

my suggestion was not to migrate it to expo modules, but to use the expo modules api when it is already available in the library consumer's app to automatically set up parts of this library, rather than use regexes to modify code

@matinzd
Copy link
Owner

matinzd commented Jun 29, 2024

Closing this in favor of the adapter library:

https://github.com/matinzd/expo-health-connect

Thanks for the contribution!

@matinzd matinzd closed this Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lateinit property requestPermission has not been initialized
3 participants