Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change parameters for bor producer selection algorithm #1208

Merged
merged 30 commits into from
Nov 27, 2024

Conversation

Raneet10
Copy link
Member

Description

This PR alters the parameters used to calculate the producer set for a span in bor as described in PIP-52.
Forum post here.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

This changes in the PR will be triggered with a hardfork named Jorvik in Amoy testnet.

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai or amoy
  • I have created new e2e tests into express-cli

@Raneet10 Raneet10 requested a review from a team November 27, 2024 05:24
@Raneet10 Raneet10 merged commit f6c0261 into develop Nov 27, 2024
9 checks passed
@Raneet10 Raneet10 deleted the raneet10/fix-producer-selection branch November 27, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants