Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DefaultBorGRPCUrl #1205

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Fix DefaultBorGRPCUrl #1205

merged 1 commit into from
Nov 14, 2024

Conversation

marcello33
Copy link
Contributor

Description

Fixes the DefaultBorGRPCUrl, just for clarity, since it would work anyway considered the removePrefix function.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

@avalkov avalkov self-requested a review November 14, 2024 15:46
@marcello33 marcello33 merged commit 9f9a1b4 into develop Nov 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cffls cffls cffls approved these changes

@avalkov avalkov avalkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcello33 @avalkov @cffls