add StateCommitted event #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gretzke
approved these changes
Sep 5, 2023
gretzke
merged commit 5f88e12
into
maticnetwork:feat/state-committed-event
1 of 2 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new event called
StateCommittedwith 2 variables:onStateReceive)Added event emission in the
commitStatefunction.Deleted unnecessary import of
IStateReceiver.Enhanced existing tests to check for emission of the event in both cases (
successtrue or false)The test
Infinite loop:was reverting, so the number of iterations was increased to get the desired result of the low-level call running out of gas, but the tx not revertingAdded
eth-gas-reporter