[bugfix] escape whitespace for filepath. Use nodejs path to make path #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same Issue here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a problem for parsing ipa file of which scheme has whitespace in it.
When the scheme name has whitespace, generated
.ipafile has white-spaced.appfile in it.Because of this, several failure can occur on this library. So I escaped path before use, but when I try to escape spaces right before
plist.readFileSync, it throws me an error. (I think it is because it escapes filename internally).Other than reading plist,
pathare used for concatenating command forked byexec, so I think it will be fine in most cases. Consider this PR, and please fix this bug. Thanks.